-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(ci): Introduce posting changelog into the Slack channel #1797
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for spirit-design-system-storybook canceled.
|
b5dccba
to
3fd5314
Compare
✅ Deploy Preview for spirit-design-system ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
3fd5314
to
3c424ba
Compare
2ede48e
to
2cc978e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So many dependencies… Did you consider making a GH action? 🤔
* | ||
* @returns {string} The formatted changelog string. | ||
*/ | ||
function format(str, packageName, prefix = '@lmc-eu') { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideas
-
Can we get rid of the package name in individual list items?
-
To reduce visual clutter, I'd consider:
- merging the two lines with "new release" and package name into one,
- maybe removing the date since it's part of the message meta data,
- for example:
**🚀 New `@lmc-eu/spirit-web` package release [3.1.0][#]**
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I think can do many things. Primarily, this should help us with fabricating release notes. I know that just copy&paste will not be enough but it can save a lot of time. So let's modify this to our liking. :-)
No, this is just a "make it work" part. Right now, I have checked out a few GHA (https://github.com/vaultinum/changelog-to-slack-action), but no one has offered us to change the formatting and other things. Maybe creating a simple package in our monorepo for this and moving the dependencies there will help reduce the clutter. |
Description
Additional context
https://github.com/kiwicom/orbit/blob/master/.github/workflows/publish.yml#L74
Issue reference
#1781