Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(ci): Introduce posting changelog into the Slack channel #1797

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

literat
Copy link
Collaborator

@literat literat commented Dec 3, 2024

@github-actions github-actions bot added the maintenance Changes to the build process or auxilary tools and libraries or other maintenance label Dec 3, 2024
Copy link

netlify bot commented Dec 3, 2024

Deploy Preview for spirit-design-system-storybook canceled.

Name Link
🔨 Latest commit 2e618fe
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/6761557ef8f4810008540d90

@literat literat force-pushed the chore/post-changelog-slack branch from b5dccba to 3fd5314 Compare December 3, 2024 18:52
Copy link

netlify bot commented Dec 3, 2024

Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit 2e618fe
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/6761557ed81b780008d3cbc2
😎 Deploy Preview https://deploy-preview-1797--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 96 (no change from production)
Accessibility: 91 (no change from production)
Best Practices: 100 (no change from production)
SEO: 91 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@literat literat force-pushed the chore/post-changelog-slack branch from 3fd5314 to 3c424ba Compare December 16, 2024 11:25
@coveralls
Copy link

Coverage Status

coverage: 79.469%. remained the same
when pulling 3c424ba on chore/post-changelog-slack
into 44eb2e1 on main.

@literat
Copy link
Collaborator Author

literat commented Dec 16, 2024

Screenshot 2024-12-16 at 12 51 49

@literat literat force-pushed the chore/post-changelog-slack branch from 2ede48e to 2cc978e Compare December 17, 2024 10:30
@literat literat marked this pull request as ready for review December 17, 2024 10:42
@literat literat requested a review from a team as a code owner December 17, 2024 10:42
Copy link
Contributor

@adamkudrna adamkudrna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So many dependencies… Did you consider making a GH action? 🤔

*
* @returns {string} The formatted changelog string.
*/
function format(str, packageName, prefix = '@lmc-eu') {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-12-16 at 12 51 49

Ideas

  • Can we get rid of the package name in individual list items?

  • To reduce visual clutter, I'd consider:

    • merging the two lines with "new release" and package name into one,
    • maybe removing the date since it's part of the message meta data,
    • for example:
    **🚀 New `@lmc-eu/spirit-web` package release [3.1.0][#]**

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think can do many things. Primarily, this should help us with fabricating release notes. I know that just copy&paste will not be enough but it can save a lot of time. So let's modify this to our liking. :-)

@literat
Copy link
Collaborator Author

literat commented Dec 17, 2024

So many dependencies… Did you consider making a GH action? 🤔

No, this is just a "make it work" part. Right now, I have checked out a few GHA (https://github.com/vaultinum/changelog-to-slack-action), but no one has offered us to change the formatting and other things. Maybe creating a simple package in our monorepo for this and moving the dependencies there will help reduce the clutter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Changes to the build process or auxilary tools and libraries or other maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants