Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(web): Introduce responsive layouts of Card #DS-1559 #1796

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

adamkudrna
Copy link
Contributor

Description

Card layout can be adjusted based on the breakpoint. To create a responsive layout, use the tablet and desktop
infixes, e.g. Card--tablet--horizontal or Card--desktop--vertical.

Additional context

image
image
image

Issue reference

https://jira.almacareer.tech/browse/DS-1559

@adamkudrna adamkudrna self-assigned this Dec 3, 2024
@github-actions github-actions bot added the feature New feature or request label Dec 3, 2024
Copy link

netlify bot commented Dec 3, 2024

Deploy Preview for spirit-design-system-storybook canceled.

Name Link
🔨 Latest commit ace462c
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/67533a72f99689000801b458

Copy link

netlify bot commented Dec 3, 2024

Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit ace462c
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/67533a72e4c560000829058b
😎 Deploy Preview https://deploy-preview-1796--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 96 (no change from production)
Accessibility: 91 (no change from production)
Best Practices: 100 (no change from production)
SEO: 91 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@crishpeen crishpeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🪄

Base automatically changed from feat/web-card to integration/card December 6, 2024 14:39
@adamkudrna adamkudrna force-pushed the feat/DS-1559-responsive-card-layout branch from d277233 to ace462c Compare December 6, 2024 17:54
Copy link
Collaborator

@literat literat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@adamkudrna adamkudrna merged commit 774f68a into integration/card Dec 12, 2024
23 checks passed
@adamkudrna adamkudrna deleted the feat/DS-1559-responsive-card-layout branch December 12, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants