Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(web): Introduce UNSTABLE Header component #DS-1523 #1794

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Feat(web): Introduce UNSTABLE Header component #DS-1523 #1794

merged 1 commit into from
Dec 10, 2024

Conversation

crishpeen
Copy link
Member

Description

Additional context

Issue reference

@crishpeen crishpeen added the run-visual-tests Runs visual regression testing on this PR label Dec 3, 2024
@crishpeen crishpeen self-assigned this Dec 3, 2024
@github-actions github-actions bot added the feature New feature or request label Dec 3, 2024
@netlify Netlify
Copy link

netlify bot commented Dec 3, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit 163e7b9
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/6758a2616cd37c00088e9516
😎 Deploy Preview https://deploy-preview-1794--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 96 (no change from production)
Accessibility: 91 (no change from production)
Best Practices: 100 (no change from production)
SEO: 91 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Dec 3, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system-storybook ready!

Name Link
🔨 Latest commit 163e7b9
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/6758a26106f1790008f36d83
😎 Deploy Preview https://deploy-preview-1794--spirit-design-system-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

literat
literat approved these changes Dec 10, 2024
View reviewed changes
Copy link
Collaborator

@literat literat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@crishpeen crishpeen merged commit 51662ca into integration/header Dec 10, 2024
23 checks passed
@crishpeen crishpeen deleted the feat/web-header branch December 10, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavelklibani pavelklibani pavelklibani approved these changes

@adamkudrna adamkudrna adamkudrna approved these changes

@literat literat literat approved these changes

@curdaj curdaj Awaiting requested review from curdaj curdaj is a code owner

Assignees

@crishpeen crishpeen

Labels
feature New feature or request run-visual-tests Runs visual regression testing on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crishpeen @literat @adamkudrna @pavelklibani