Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Introduce isFluid prop to Container #1793

Merged
merged 3 commits into from
Dec 10, 2024
Merged

Conversation

crishpeen
Copy link
Member

Description

Additional context

Issue reference

@crishpeen crishpeen added the run-visual-tests Runs visual regression testing on this PR label Dec 3, 2024
@github-actions github-actions bot added the feature New feature or request label Dec 3, 2024
Copy link

netlify bot commented Dec 3, 2024

Deploy Preview for spirit-design-system-storybook ready!

Name Link
🔨 Latest commit 9e900a0
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/6751c76257bf1a0008db7072
😎 Deploy Preview https://deploy-preview-1793--spirit-design-system-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 3, 2024

Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit 9e900a0
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/6751c7620f7d1300088d256f
😎 Deploy Preview https://deploy-preview-1793--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 96 (no change from production)
Accessibility: 91 (no change from production)
Best Practices: 100 (no change from production)
SEO: 91 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@coveralls
Copy link

coveralls commented Dec 3, 2024

Coverage Status

coverage: 79.469%. remained the same
when pulling 9e900a0 on feat/fluid-container
into c3ad4b2 on main.

@crishpeen crishpeen force-pushed the docs/section-container branch from c5a7e6e to 7129ec0 Compare December 5, 2024 15:10
Base automatically changed from docs/section-container to main December 5, 2024 15:21
@crishpeen crishpeen force-pushed the feat/fluid-container branch from f624f79 to 9e900a0 Compare December 5, 2024 15:31
Copy link
Contributor

@adamkudrna adamkudrna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Web and Twig LGTM.

Copy link
Collaborator

@literat literat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@crishpeen crishpeen merged commit 8f86d61 into main Dec 10, 2024
35 checks passed
@crishpeen crishpeen deleted the feat/fluid-container branch December 10, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request run-visual-tests Runs visual regression testing on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants