Demo: Move Container into (Docs)Section in all components #1791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crishpeen
requested review from
literat,
adamkudrna,
pavelklibani,
a team and
curdaj
as code owners
github-actions
bot
added
the
documentation
✅ Deploy Preview for spirit-design-system ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for spirit-design-system-storybook canceled.
|
curdaj
approved these changes
Dec 5, 2024
pavelklibani
approved these changes
Dec 5, 2024
adamkudrna
approved these changes
Dec 5, 2024
This way the Container can be optional - see Footer, Header & Container demos. This allows us to create nice demos for full width components.
…um prop This way the Container can be optional - see Footer, Header & Container demos. This allows us to create nice demos for full width components.
…m prop This way the Container can be optional - see Header & Container demos. This allows us to create nice demos for full width components.
crishpeen
force-pushed
the
docs/section-container
branch
from
c5a7e6e to
7129ec0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This way the Container can be optional - see Footer, Header & Container demos.
This allows us to create nice demos for full-width components.
Otherwise, we were limited by the Container from layout.
Sorry for a big PR 😬.
Additional context
Issue reference