Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: Collapse API - isDisposable #1788

Merged
merged 4 commits into from
Dec 9, 2024
Merged

Refactor: Collapse API - isDisposable #1788

merged 4 commits into from
Dec 9, 2024

Conversation

pavelklibani
Copy link
Contributor

@pavelklibani pavelklibani commented Dec 2, 2024 •
edited
Loading

Description

Web & Twig

  • Attribute data-spirit-more was changed to data-spirit-is-disposable
  • Updated tests
  • Updated demos
  • Added deprecation messages and updated DEPRECATIONS.md file

React

  • Prop hideOnCollapse was changed to isDisposable
  • Updated tests
  • Updated stories in storybook
  • Updated demos
  • Added missing test for Collapse component
  • Created codemod for the prop change
  • Added deprecation messages and updated DEPRECATIONS.md file

Additional context

Issue reference

Collapse: lepší API rozbalování

@pavelklibani pavelklibani self-assigned this Dec 2, 2024
@github-actions github-actions bot added the refactoring A code change that neither fixes a bug nor adds a feature label Dec 2, 2024
@netlify Netlify
Copy link

netlify bot commented Dec 2, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system-storybook ready!

Name Link
🔨 Latest commit 7b4be76
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/6756ca9841e1050008ce7690
😎 Deploy Preview https://deploy-preview-1788--spirit-design-system-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@pavelklibani pavelklibani added run-visual-tests Runs visual regression testing on this PR and removed refactoring A code change that neither fixes a bug nor adds a feature labels Dec 2, 2024
@netlify Netlify
Copy link

netlify bot commented Dec 2, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit 7b4be76
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/6756ca9841e1050008ce7692
😎 Deploy Preview https://deploy-preview-1788--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 96 (no change from production)
Accessibility: 91 (no change from production)
Best Practices: 100 (no change from production)
SEO: 91 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@pavelklibani pavelklibani force-pushed the refactor/ds-832-collapse-api branch from 5ace823 to 9422a58 Compare December 2, 2024 17:20
crishpeen
crishpeen reviewed Dec 3, 2024
View reviewed changes
packages/web-react/DEPRECATIONS.md Outdated Show resolved Hide resolved
packages/web-react/src/components/Collapse/README.md Outdated Show resolved Hide resolved
packages/web-react/src/components/Collapse/README.md Outdated Show resolved Hide resolved
packages/web-react/src/components/Collapse/README.md Outdated Show resolved Hide resolved
packages/web-react/src/components/Collapse/__tests__/Collapse.test.tsx Outdated Show resolved Hide resolved
packages/web-react/src/components/Collapse/__tests__/Collapse.test.tsx Outdated Show resolved Hide resolved
packages/web-react/src/components/Collapse/stories/UncontrolledCollapse.stories.tsx Outdated Show resolved Hide resolved
packages/web-twig/src/Resources/components/Collapse/README.md Outdated Show resolved Hide resolved
literat
literat approved these changes Dec 4, 2024
View reviewed changes
Copy link
Collaborator

@literat literat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done 👍

@pavelklibani pavelklibani force-pushed the refactor/ds-832-collapse-api branch from bb47240 to 7d0d8e7 Compare December 5, 2024 09:05
@pavelklibani
Refactor(web): Collapse API attribute changed
a7cea58 
- attribute `data-spirit-more` changed to `data-spirit-is-disposable`

- Solves DS-832
@pavelklibani
Refactor(web-twig): Collapse API attribute changed
93e4b9a 
- attribute `data-spirit-more` changed to `data-spirit-is-disposable`

- Solves DS-832
@pavelklibani
Refactor(web-react): Collapse API prop changed
bdf4bf9 
- prop `hideOnCollapse`` changed to `isDisposable`

- Solves DS-832
@pavelklibani
Feat(codemod): Add isDisposable codemod for Collapse
7b4be76 
- New codemod mod for changing `hideonCollapse` prop to `isDisposable` in Collapse component

- Solves #832
@pavelklibani pavelklibani force-pushed the refactor/ds-832-collapse-api branch from 7d0d8e7 to 7b4be76 Compare December 9, 2024 10:46
@pavelklibani
Copy link
Contributor Author

rebase & resolve conflict

@coveralls
Copy link

Coverage Status

coverage: 79.469%. remained the same
when pulling 7b4be76 on refactor/ds-832-collapse-api
into c3ad4b2 on main.

@pavelklibani pavelklibani merged commit 59296dc into main Dec 9, 2024
35 checks passed
@pavelklibani pavelklibani deleted the refactor/ds-832-collapse-api branch December 9, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@curdaj curdaj curdaj approved these changes

@crishpeen crishpeen crishpeen approved these changes

@literat literat literat approved these changes

@adamkudrna adamkudrna Awaiting requested review from adamkudrna adamkudrna is a code owner

Assignees

@pavelklibani pavelklibani

Labels
run-visual-tests Runs visual regression testing on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pavelklibani @coveralls @literat @crishpeen @curdaj