Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(web-react): Failing type in PaginationLink #DS-1586 #1761

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

curdaj
Copy link
Contributor

@curdaj curdaj commented Nov 19, 2024

Description

Additional context

Issue reference

@github-actions github-actions bot added the bug Something isn't working label Nov 19, 2024
Copy link

netlify bot commented Nov 19, 2024

Deploy Preview for spirit-design-system-storybook canceled.

Name Link
🔨 Latest commit 5dc6cee
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/673f05d52d5be600086ee5ba

Copy link

netlify bot commented Nov 19, 2024

Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit 5dc6cee
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/673f05d55dcffd0008e9ae32
😎 Deploy Preview https://deploy-preview-1761--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 96 (no change from production)
Accessibility: 93 (no change from production)
Best Practices: 100 (no change from production)
SEO: 90 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@literat literat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@curdaj curdaj marked this pull request as ready for review November 21, 2024 08:25
@curdaj curdaj requested review from pavelklibani and a team as code owners November 21, 2024 08:25
@curdaj curdaj force-pushed the fix/ds-1568-failing-paginationLink branch from a52d2ed to 5dc6cee Compare November 21, 2024 10:05
@curdaj curdaj merged commit bca92a5 into main Nov 21, 2024
23 checks passed
@curdaj curdaj deleted the fix/ds-1568-failing-paginationLink branch November 21, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants