Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(web): Introduce Card component #DS-1397 #1751

Merged
merged 3 commits into from
Dec 6, 2024
Merged

Feat(web): Introduce Card component #DS-1397 #1751

merged 3 commits into from
Dec 6, 2024

Conversation

adamkudrna
Copy link
Contributor

@adamkudrna adamkudrna commented Nov 12, 2024 •
edited
Loading

@adamkudrna adamkudrna self-assigned this Nov 12, 2024
@github-actions github-actions bot added the feature New feature or request label Nov 12, 2024
@adamkudrna adamkudrna force-pushed the feat/web-card branch 2 times, most recently from 4961e78 to 1e80a46 Compare November 12, 2024 15:09
@netlify Netlify
Copy link

netlify bot commented Nov 12, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system-storybook canceled.

Name Link
🔨 Latest commit 396794b
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/67530661a7c4340008b5dc6e

@netlify Netlify
Copy link

netlify bot commented Nov 12, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit 396794b
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/67530661a1aa840008f60f25
😎 Deploy Preview https://deploy-preview-1751--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 96 (no change from production)
Accessibility: 91 (no change from production)
Best Practices: 100 (no change from production)
SEO: 91 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@literat
Copy link
Collaborator

literat commented Nov 12, 2024

❤️

crishpeen
crishpeen reviewed Nov 19, 2024
View reviewed changes
packages/web/src/scss/components/Card/_Card.scss Outdated Show resolved Hide resolved
packages/web/src/scss/components/Card/_CardActions.scss Outdated Show resolved Hide resolved
packages/web/src/scss/components/Card/_CardBody.scss Outdated Show resolved Hide resolved
packages/web/src/scss/components/Card/_CardEyebrow.scss Show resolved Hide resolved
packages/web/src/scss/components/Card/_CardLink.scss Show resolved Hide resolved
packages/web/src/scss/components/Card/_CardMedia.scss Outdated Show resolved Hide resolved
packages/web/src/scss/components/Card/_CardMedia.scss Show resolved Hide resolved
packages/web/src/scss/components/Card/_CardTitle.scss Show resolved Hide resolved
packages/web/src/scss/components/Card/_theme.scss Outdated Show resolved Hide resolved
packages/web/src/scss/components/Card/index.html Show resolved Hide resolved
@crishpeen
Copy link
Member

crishpeen commented Nov 19, 2024 •
edited
Loading

Horizontal cards do not fit on mobile screen :(

@adamkudrna
Copy link
Contributor Author

Horizontal cards do not fit on mobile screen :(

I added a separate set of media sizes for horizontal cards but we still need to get back to this.

@adamkudrna
Copy link
Contributor Author

Horizontal cards do not fit on mobile screen :(

I added a separate set of media sizes for horizontal cards but we still need to get back to this.

I tweaked the media subcomponent so nothing is overflowing now.

Snímek obrazovky 2024-11-25 v 08 23 30

@adamkudrna adamkudrna marked this pull request as ready for review November 25, 2024 07:25
@adamkudrna adamkudrna requested a review from crishpeen November 25, 2024 07:25
@adamkudrna adamkudrna mentioned this pull request Nov 25, 2024
Merged
crishpeen
crishpeen reviewed Nov 26, 2024
View reviewed changes
packages/web/src/scss/components/Card/README.md Outdated Show resolved Hide resolved
packages/web/src/scss/components/Card/README.md Outdated Show resolved Hide resolved
packages/web/src/scss/components/Card/README.md Outdated Show resolved Hide resolved
packages/web/src/scss/components/Card/README.md Show resolved Hide resolved
packages/web/src/scss/components/Card/README.md Outdated Show resolved Hide resolved
packages/web/src/scss/components/Card/_CardMedia.scss Outdated Show resolved Hide resolved
packages/web/src/scss/components/Card/_Card.scss Outdated Show resolved Hide resolved
packages/web/src/scss/components/Card/_CardMedia.scss Show resolved Hide resolved
packages/web/src/scss/components/Card/_theme.scss Outdated Show resolved Hide resolved
packages/web/src/scss/components/Card/index.html Outdated Show resolved Hide resolved
@adamkudrna adamkudrna merged commit 47c76d1 into integration/card Dec 6, 2024
23 checks passed
@adamkudrna adamkudrna deleted the feat/web-card branch December 6, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@literat literat literat left review comments

@pavelklibani pavelklibani pavelklibani approved these changes

@crishpeen crishpeen crishpeen approved these changes

@curdaj curdaj Awaiting requested review from curdaj

Assignees

@adamkudrna adamkudrna

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adamkudrna @literat @crishpeen @pavelklibani