Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor(web): Abstract spacing tools to generate any custom properties cascade #DS-1546 #1739

Merged

Conversation

adamkudrna
Copy link
Contributor

Description

Additional context

Issue reference

https://jira.almacareer.tech/browse/DS-1546

@adamkudrna adamkudrna added the run-visual-tests Runs visual regression testing on this PR label Oct 31, 2024
@adamkudrna adamkudrna self-assigned this Oct 31, 2024
@github-actions github-actions bot added the refactoring A code change that neither fixes a bug nor adds a feature label Oct 31, 2024
Copy link

netlify bot commented Oct 31, 2024

Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit bec3f68
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/672c94b49eaadf0008819329
😎 Deploy Preview https://deploy-preview-1739--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 96 (no change from production)
Accessibility: 91 (🔴 down 2 from production)
Best Practices: 100 (no change from production)
SEO: 91 (🟢 up 1 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 31, 2024

Deploy Preview for spirit-design-system-storybook canceled.

Name Link
🔨 Latest commit bec3f68
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/672c94b4ffe8cc0008928de5

Copy link
Contributor

Copy link
Contributor

@adamkudrna adamkudrna force-pushed the refactor/custom-property-cascade branch from e73093b to 7afa852 Compare October 31, 2024 19:31
@adamkudrna adamkudrna requested a review from dlouhak October 31, 2024 19:40
@crishpeen crishpeen force-pushed the integration/BC-v3-design-tokens branch from fa33a68 to bab5113 Compare November 5, 2024 12:47
@crishpeen crishpeen force-pushed the refactor/custom-property-cascade branch from 7afa852 to 4a8e91a Compare November 5, 2024 12:54
@adamkudrna adamkudrna force-pushed the refactor/custom-property-cascade branch from 760d6e7 to deaa94f Compare November 7, 2024 10:04
packages/web/src/scss/components/Stack/_Stack.scss Outdated Show resolved Hide resolved
packages/web/src/scss/components/Stack/_Stack.scss Outdated Show resolved Hide resolved
@adamkudrna adamkudrna force-pushed the refactor/custom-property-cascade branch from deaa94f to bec3f68 Compare November 7, 2024 10:21
@adamkudrna adamkudrna merged commit b2cd9aa into integration/BC-v3-design-tokens Nov 7, 2024
23 checks passed
@adamkudrna adamkudrna deleted the refactor/custom-property-cascade branch November 7, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring A code change that neither fixes a bug nor adds a feature run-visual-tests Runs visual regression testing on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants