-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor(web): Abstract spacing tools to generate any custom properties cascade #DS-1546 #1739
Merged
adamkudrna
merged 1 commit into
integration/BC-v3-design-tokens
from
refactor/custom-property-cascade
Nov 7, 2024
Merged
Refactor(web): Abstract spacing tools to generate any custom properties cascade #DS-1546 #1739
adamkudrna
merged 1 commit into
integration/BC-v3-design-tokens
from
refactor/custom-property-cascade
Nov 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamkudrna
requested review from
literat,
crishpeen,
pavelklibani,
curdaj and
a team
as code owners
October 31, 2024 19:15
github-actions
bot
added
the
refactoring
A code change that neither fixes a bug nor adds a feature
label
Oct 31, 2024
✅ Deploy Preview for spirit-design-system ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for spirit-design-system-storybook canceled.
|
Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/11618405034/artifacts/2130180770 |
Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/11618405070/artifacts/2130180900 |
adamkudrna
force-pushed
the
refactor/custom-property-cascade
branch
from
October 31, 2024 19:31
e73093b
to
7afa852
Compare
adamkudrna
commented
Oct 31, 2024
literat
reviewed
Nov 4, 2024
literat
reviewed
Nov 4, 2024
crishpeen
force-pushed
the
integration/BC-v3-design-tokens
branch
from
November 5, 2024 12:47
fa33a68
to
bab5113
Compare
crishpeen
force-pushed
the
refactor/custom-property-cascade
branch
from
November 5, 2024 12:54
7afa852
to
4a8e91a
Compare
crishpeen
reviewed
Nov 5, 2024
adamkudrna
commented
Nov 5, 2024
adamkudrna
force-pushed
the
refactor/custom-property-cascade
branch
from
November 7, 2024 10:04
760d6e7
to
deaa94f
Compare
crishpeen
approved these changes
Nov 7, 2024
…es cascade #DS-1546
adamkudrna
force-pushed
the
refactor/custom-property-cascade
branch
from
November 7, 2024 10:21
deaa94f
to
bec3f68
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
refactoring
A code change that neither fixes a bug nor adds a feature
run-visual-tests
Runs visual regression testing on this PR
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Additional context
Issue reference
https://jira.almacareer.tech/browse/DS-1546