Refactor(web): Unify generation of responsive spacing and alignment in layout components #DS-1423 #1734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamkudrna
requested review from
literat,
crishpeen,
pavelklibani,
curdaj and
a team
as code owners
github-actions
bot
added
the
refactoring
✅ Deploy Preview for spirit-design-system ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for spirit-design-system-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
adamkudrna
commented
Oct 29, 2024
crishpeen
approved these changes
Oct 31, 2024
curdaj
approved these changes
Oct 31, 2024
adamkudrna
force-pushed
the
feature/themeable-tokens-autocomplete
branch
from
43b8843 to
ce9715b
Compare
Base automatically changed from
feature/themeable-tokens-autocomplete
to
integration/BC-v3-design-tokens
October 31, 2024 12:19
…n layout components #DS-1423 In `Flex`, `Grid`, and `Stack` components: - responsive spacing is now generated exclusively with the spacing tools, - responsive alignment is now generated exclusively with the dictionary tools.
adamkudrna
force-pushed
the
refactor/generated-layouts-and-spacing
branch
from
8a44893 to
3712aff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In
Flex,Grid, andStackcomponents:Additional context
We want to approach all layout components the same way so they are easily extensible.
Issue reference
https://jira.almacareer.tech/browse/DS-1423