Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs(web-twig): Introduce Migration Guide to version 4 #1731

Merged

Conversation

crishpeen
Copy link
Member

Description

Additional context

Issue reference

@crishpeen crishpeen requested a review from a team as a code owner October 29, 2024 12:43
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 29, 2024
Copy link

netlify bot commented Oct 29, 2024

Deploy Preview for spirit-design-system-storybook ready!

Name Link
🔨 Latest commit c84a594
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/672355f9e92c190008aad36f
😎 Deploy Preview https://deploy-preview-1731--spirit-design-system-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 29, 2024

Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit c84a594
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/672355f9d7a191000858644d
😎 Deploy Preview https://deploy-preview-1731--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 96 (no change from production)
Accessibility: 91 (🔴 down 2 from production)
Best Practices: 100 (no change from production)
SEO: 91 (🟢 up 1 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@crishpeen crishpeen force-pushed the docs/v3-twig-migration-guide branch from 1500d31 to c84a594 Compare October 31, 2024 10:03
@coveralls
Copy link

Coverage Status

coverage: 96.838%. remained the same
when pulling c84a594 on docs/v3-twig-migration-guide
into 9aacc57 on integration/BC-v3-design-tokens.

Copy link
Collaborator

@literat literat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@crishpeen crishpeen merged commit 268eb4b into integration/BC-v3-design-tokens Nov 5, 2024
29 checks passed
@crishpeen crishpeen deleted the docs/v3-twig-migration-guide branch November 5, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants