Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(exporter-tokens): Pass all tokens to the computeTokensByApplyingThemes so references work #1729

Merged

Conversation

crishpeen
Copy link
Member

Description

Apparently, the first argument is needed for token references to work. As we introduced primitives, we need to send this parameter, too, because otherwise the values are not thematized or something—they are wrong.

Hopefully, this is the right way, it is still not documented by Supernova. 🙃

Additional context

Issue reference

@crishpeen crishpeen requested review from literat, pavelklibani, curdaj and a team as code owners October 24, 2024 13:36
Copy link

netlify bot commented Oct 24, 2024

Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit 54800f5
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/672351a71bc01b0008ac3b43
😎 Deploy Preview https://deploy-preview-1729--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 95 (🔴 down 1 from production)
Accessibility: 93 (no change from production)
Best Practices: 100 (no change from production)
SEO: 90 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 24, 2024

Deploy Preview for spirit-design-system-storybook canceled.

Name Link
🔨 Latest commit 54800f5
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/672351a7f3ca740008f0f7cc

@github-actions github-actions bot added the bug Something isn't working label Oct 24, 2024
@crishpeen
Copy link
Member Author

For future reference, when we introduce Primitives filtering to the exporter, we will probably need to send ALL TOKENS (including primitives) to this function as a first attribute.

If the referenced token is not found, the non-themed value is used. This makes it difficult to debug (you have to check the Supernova app to see the table with values and compare the output).

cc @pavelklibani @curdaj @literat

@crishpeen crishpeen force-pushed the fix/exporter-computeTokensByApplyingThemes-parameters branch from 22efca1 to 54800f5 Compare October 31, 2024 09:45
@crishpeen crishpeen merged commit 1abf05c into main Oct 31, 2024
23 checks passed
@crishpeen crishpeen deleted the fix/exporter-computeTokensByApplyingThemes-parameters branch October 31, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants