Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs(web-react): Introduce Migration Guide to version 3 #1723

Merged
merged 2 commits into from
Oct 31, 2024
Merged

Docs(web-react): Introduce Migration Guide to version 3 #1723

merged 2 commits into from
Oct 31, 2024

Conversation

crishpeen
Copy link
Member

Description

Additional context

Issue reference

https://jira.almacareer.tech/browse/DS-1492

@github-actions github-actions bot added the feature New feature or request label Oct 22, 2024
@netlify Netlify
Copy link

netlify bot commented Oct 22, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit 5a2f422
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/67235627565eef000809b39d
😎 Deploy Preview https://deploy-preview-1723--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 96 (no change from production)
Accessibility: 91 (🔴 down 2 from production)
Best Practices: 100 (no change from production)
SEO: 91 (🟢 up 1 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Oct 22, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system-storybook canceled.

Name Link
🔨 Latest commit 5a2f422
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/67235627f398b80008b5eb14

adamkudrna
adamkudrna approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@adamkudrna adamkudrna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't check if the list of changes is complete, but what's here looks good.

docs/migrations/web-react/MIGRATION-v3.md Show resolved Hide resolved
docs/migrations/web-react/MIGRATION-v3.md Outdated Show resolved Hide resolved
docs/migrations/web-react/MIGRATION-v3.md Outdated Show resolved Hide resolved
@crishpeen crishpeen force-pushed the feat/v3-react-migration-guide branch from be2fe66 to 70d8ae6 Compare October 31, 2024 09:38
@coveralls
Copy link

Coverage Status

coverage: 96.838%. remained the same
when pulling 70d8ae6 on feat/v3-react-migration-guide
into 9aacc57 on integration/BC-v3-design-tokens.

@crishpeen crishpeen force-pushed the feat/v3-react-migration-guide branch from 70d8ae6 to 5a2f422 Compare October 31, 2024 10:04
@crishpeen crishpeen merged commit c58e981 into integration/BC-v3-design-tokens Oct 31, 2024
20 checks passed
@crishpeen crishpeen deleted the feat/v3-react-migration-guide branch October 31, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@literat literat literat left review comments

@pavelklibani pavelklibani pavelklibani approved these changes

@adamkudrna adamkudrna adamkudrna approved these changes

@curdaj curdaj Awaiting requested review from curdaj

Assignees

@crishpeen crishpeen

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@crishpeen @coveralls @literat @adamkudrna @pavelklibani