-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deps(web, web-react, web-twig): Implement sass-embedded library #1721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelklibani
requested review from
literat,
curdaj,
a team,
adamkudrna and
crishpeen
as code owners
October 22, 2024 11:49
✅ Deploy Preview for spirit-design-system-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for spirit-design-system ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
curdaj
approved these changes
Oct 23, 2024
literat
reviewed
Oct 23, 2024
literat
reviewed
Oct 24, 2024
literat
approved these changes
Oct 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great 👍
crishpeen
approved these changes
Oct 29, 2024
pavelklibani
force-pushed
the
deps/ds-1499-sass-embedded-lib
branch
2 times, most recently
from
October 29, 2024 12:40
9927320
to
52d3721
Compare
- use sass-embedded instead of sass - @see https://sass-lang.com/documentation/breaking-changes/legacy-js-api/#bundlers
pavelklibani
force-pushed
the
deps/ds-1499-sass-embedded-lib
branch
from
October 31, 2024 10:04
52d3721
to
298ccfa
Compare
rebased with main |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
sass
has been replaced withsass-embedded
for improved performance and modern features.More info:
https://sass-lang.com/documentation/breaking-changes/legacy-js-api/#bundlers
https://webpack.js.org/loaders/sass-loader/#api
https://vite.dev/config/shared-options.html#css-preprocessoroptions
Additional context
Note
DS-1499 and DS-1498 solved together
Example Build Times
Issue reference
Use sass-embedded module instead of sass (discovery)
Future BC in sass module