Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deps(web, web-react, web-twig): Implement sass-embedded library #1721

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

pavelklibani
Copy link
Contributor

@pavelklibani pavelklibani commented Oct 22, 2024

Description

sass has been replaced with sass-embedded for improved performance and modern features.

More info:
https://sass-lang.com/documentation/breaking-changes/legacy-js-api/#bundlers
https://webpack.js.org/loaders/sass-loader/#api
https://vite.dev/config/shared-options.html#css-preprocessoroptions

Additional context

Note

DS-1499 and DS-1498 solved together

Example Build Times
sass
make build 133.53s user 15.91s system 277% cpu 53.807 total
make build 132.87s user 15.88s system 277% cpu 53.598 total
make build 135.18s user 17.26s system 274% cpu 55.499 total
make build 133.16s user 16.08s system 276% cpu 53.998 total
make build 132.05s user 15.87s system 278% cpu 53.057 total
sass-embedded
make build 132.38s user 16.19s system 269% cpu 55.157 total
make build 131.62s user 16.23s system 274% cpu 53.863 total
make build 130.95s user 15.63s system 276% cpu 52.981 total
make build 132.33s user 16.03s system 272% cpu 54.535 total
make build 133.00s user 15.84s system 273% cpu 54.416 total

Issue reference

Use sass-embedded module instead of sass (discovery)
Future BC in sass module

Copy link

netlify bot commented Oct 22, 2024

Deploy Preview for spirit-design-system-storybook ready!

Name Link
🔨 Latest commit 298ccfa
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/672356376beb3c00085c18f7
😎 Deploy Preview https://deploy-preview-1721--spirit-design-system-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 22, 2024

Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit 298ccfa
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/672356372329f6000839f346
😎 Deploy Preview https://deploy-preview-1721--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 96 (no change from production)
Accessibility: 93 (no change from production)
Best Practices: 100 (no change from production)
SEO: 90 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@literat literat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great 👍

@pavelklibani pavelklibani force-pushed the deps/ds-1499-sass-embedded-lib branch 2 times, most recently from 9927320 to 52d3721 Compare October 29, 2024 12:40
@pavelklibani pavelklibani force-pushed the deps/ds-1499-sass-embedded-lib branch from 52d3721 to 298ccfa Compare October 31, 2024 10:04
@pavelklibani
Copy link
Contributor Author

rebased with main

@pavelklibani pavelklibani merged commit 07df504 into main Oct 31, 2024
29 checks passed
@pavelklibani pavelklibani deleted the deps/ds-1499-sass-embedded-lib branch October 31, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants