Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Introduce decision about the themes feature #DS-1489 #1720

Merged
merged 5 commits into from
Oct 31, 2024

Conversation

adamkudrna
Copy link
Contributor

Description

Additional context

Issue reference

https://jira.almacareer.tech/browse/DS-1489

@adamkudrna adamkudrna requested a review from a team as a code owner October 17, 2024 14:26
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 17, 2024
Copy link

netlify bot commented Oct 17, 2024

Deploy Preview for spirit-design-system-storybook ready!

Name Link
🔨 Latest commit 5e33435
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/67211cb6d9b5fe00086ad0bd
😎 Deploy Preview https://deploy-preview-1720--spirit-design-system-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 17, 2024

Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit 5e33435
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/67211cb637944700081bcfa6
😎 Deploy Preview https://deploy-preview-1720--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 96 (🟢 up 1 from production)
Accessibility: 93 (no change from production)
Best Practices: 100 (no change from production)
SEO: 90 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@crishpeen crishpeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this can be merged in the main branch? It is independent on the integration branch and it would be nice to have in the history before it.

docs/decisions/008-themes.md Outdated Show resolved Hide resolved
docs/decisions/008-themes.md Outdated Show resolved Hide resolved
docs/decisions/008-themes.md Outdated Show resolved Hide resolved
docs/decisions/008-themes.md Outdated Show resolved Hide resolved
@adamkudrna adamkudrna force-pushed the docs/themes-decision branch from 31bb89d to b8bead5 Compare October 17, 2024 15:21
@adamkudrna adamkudrna changed the base branch from integration/BC-v3-design-tokens to main October 17, 2024 15:21
@adamkudrna adamkudrna requested a review from crishpeen October 17, 2024 15:21
@adamkudrna adamkudrna merged commit 82efac8 into main Oct 31, 2024
22 of 23 checks passed
@adamkudrna adamkudrna deleted the docs/themes-decision branch October 31, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants