Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Rename global to global-tokens and remove globals settings #1718

Merged
merged 4 commits into from
Oct 23, 2024

Conversation

crishpeen
Copy link
Member

Description

Additional context

Issue reference

@github-actions github-actions bot added the feature New feature or request label Oct 17, 2024
@coveralls
Copy link

coveralls commented Oct 17, 2024

Coverage Status

coverage: 96.838%. remained the same
when pulling 5bafe34 on feat/global-tokens
into f5ad8a7 on integration/BC-v3-design-tokens.

Copy link

netlify bot commented Oct 17, 2024

Deploy Preview for spirit-design-system-storybook canceled.

Name Link
🔨 Latest commit 135723b
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/67190239ca7883000881a3b0

Copy link

netlify bot commented Oct 17, 2024

Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit 135723b
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/67190239ab42b60008c4d6ef
😎 Deploy Preview https://deploy-preview-1718--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 96 (no change from production)
Accessibility: 91 (🔴 down 2 from production)
Best Practices: 100 (no change from production)
SEO: 91 (🟢 up 1 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@literat literat force-pushed the integration/BC-v3-design-tokens branch from 912c9b2 to f5ad8a7 Compare October 17, 2024 14:17
@adamkudrna adamkudrna marked this pull request as ready for review October 23, 2024 14:37
@adamkudrna adamkudrna merged commit dee02f6 into integration/BC-v3-design-tokens Oct 23, 2024
23 checks passed
@adamkudrna adamkudrna deleted the feat/global-tokens branch October 23, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants