-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix(exporter-variables-scss): API change in Supernova.io SDK #1698
Merged
+114
−106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
literat
requested review from
crishpeen,
pavelklibani,
curdaj and
a team
as code owners
October 11, 2024 15:03
✅ Deploy Preview for spirit-design-system-storybook canceled.
|
✅ Deploy Preview for spirit-design-system ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Modify Renovate Config to pin all versions in |
pavelklibani
approved these changes
Oct 14, 2024
literat
commented
Oct 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, finally it is working 👍
pavelklibani
force-pushed
the
fix/variables-exporter-api
branch
2 times, most recently
from
October 14, 2024 14:41
22f5c23
to
881189c
Compare
* undocumented API change in `sdk.tokens.computeTokensByApplyingThemes` * the API is now same as in `@supernovaio/sdk` where 3 arguments are needed
… in gradients - fixed by Supernova
* and also pin versions to avoid API breaking
pavelklibani
force-pushed
the
fix/variables-exporter-api
branch
from
October 14, 2024 14:49
881189c
to
8786232
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
sdk.tokens.computeTokensByApplyingThemes
@supernovaio/sdk
where 3 arguments are neededAdditional context
https://supernovafriends.slack.com/archives/C020NGTNA0H/p1728651624309829
Issue reference