Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(exporter-variables-scss): API change in Supernova.io SDK #1698

Merged
merged 4 commits into from
Oct 14, 2024

Conversation

literat
Copy link
Collaborator

@literat literat commented Oct 11, 2024

Description

  • undocumented API change in sdk.tokens.computeTokensByApplyingThemes
  • the API is now same as in @supernovaio/sdk where 3 arguments are needed

Additional context

https://supernovafriends.slack.com/archives/C020NGTNA0H/p1728651624309829

Issue reference

@literat literat requested review from crishpeen, pavelklibani, curdaj and a team as code owners October 11, 2024 15:03
@github-actions github-actions bot added the bug Something isn't working label Oct 11, 2024
Copy link

netlify bot commented Oct 11, 2024

Deploy Preview for spirit-design-system-storybook canceled.

Name Link
🔨 Latest commit 8786232
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/670d2f67f9064b0008c7a95a

Copy link

netlify bot commented Oct 11, 2024

Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit 8786232
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/670d2f67426b9c0008467487
😎 Deploy Preview https://deploy-preview-1698--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 96 (🟢 up 1 from production)
Accessibility: 93 (no change from production)
Best Practices: 100 (no change from production)
SEO: 82 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@literat
Copy link
Collaborator Author

literat commented Oct 13, 2024

Modify Renovate Config to pin all versions in /exporters directory, so the versions of the SDK will be fixed.

Copy link
Collaborator Author

@literat literat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, finally it is working 👍

@pavelklibani pavelklibani force-pushed the fix/variables-exporter-api branch 2 times, most recently from 22f5c23 to 881189c Compare October 14, 2024 14:41
literat and others added 4 commits October 14, 2024 16:47
  * undocumented API change in `sdk.tokens.computeTokensByApplyingThemes`
  * the API is now same as in `@supernovaio/sdk` where 3 arguments are needed
  * and also pin versions to avoid API breaking
@pavelklibani pavelklibani force-pushed the fix/variables-exporter-api branch from 881189c to 8786232 Compare October 14, 2024 14:49
@pavelklibani pavelklibani merged commit b45c025 into main Oct 14, 2024
20 checks passed
@pavelklibani pavelklibani deleted the fix/variables-exporter-api branch October 14, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants