Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs(web): Introduce General Changes into the Migration Guide #DS-1489 #1696

Merged

Conversation

crishpeen
Copy link
Member

Description

Additional context

Issue reference

@crishpeen crishpeen requested a review from a team as a code owner October 10, 2024 13:36
Copy link

netlify bot commented Oct 10, 2024

Deploy Preview for spirit-design-system-storybook canceled.

Name Link
🔨 Latest commit b783fd5
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/67112232dd96bf000843af91

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 10, 2024
Copy link

netlify bot commented Oct 10, 2024

Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit b783fd5
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/67112232dcae1b000813cf6c
😎 Deploy Preview https://deploy-preview-1696--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 96 (🟢 up 1 from production)
Accessibility: 91 (🔴 down 2 from production)
Best Practices: 100 (no change from production)
SEO: 83 (🟢 up 1 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@coveralls
Copy link

Coverage Status

coverage: 78.782%. remained the same
when pulling 7fd4780 on docs/web-migration-general-changes
into 852b0e6 on integration/BC-v3-design-tokens.

@coveralls
Copy link

coveralls commented Oct 10, 2024

Coverage Status

coverage: 96.838%. remained the same
when pulling e7c27d7 on docs/web-migration-general-changes
into f5ad8a7 on integration/BC-v3-design-tokens.

@crishpeen crishpeen requested a review from adamkudrna October 15, 2024 07:01
@literat literat force-pushed the integration/BC-v3-design-tokens branch from 9b2178f to cb6f97e Compare October 15, 2024 07:42
@crishpeen crishpeen force-pushed the docs/web-migration-general-changes branch from 7fd4780 to 5728b54 Compare October 15, 2024 14:12
Copy link
Contributor

@adamkudrna adamkudrna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! 👍🏻 I think the introduction needs more attention, the rest is just details.

docs/migrations/web/MIGRATION-v3.md Outdated Show resolved Hide resolved
docs/migrations/web/MIGRATION-v3.md Outdated Show resolved Hide resolved
docs/migrations/web/MIGRATION-v3.md Outdated Show resolved Hide resolved
docs/migrations/web/MIGRATION-v3.md Show resolved Hide resolved
docs/migrations/web/MIGRATION-v3.md Outdated Show resolved Hide resolved
docs/migrations/web/MIGRATION-v3.md Outdated Show resolved Hide resolved
docs/migrations/web/MIGRATION-v3.md Outdated Show resolved Hide resolved
docs/migrations/web/MIGRATION-v3.md Outdated Show resolved Hide resolved
docs/migrations/web/MIGRATION-v3.md Outdated Show resolved Hide resolved
docs/migrations/web/MIGRATION-v3.md Outdated Show resolved Hide resolved
@literat literat force-pushed the integration/BC-v3-design-tokens branch from cb6f97e to 83df04c Compare October 16, 2024 13:53
@crishpeen crishpeen force-pushed the docs/web-migration-general-changes branch from 5728b54 to db21506 Compare October 17, 2024 07:38
@literat literat force-pushed the integration/BC-v3-design-tokens branch from 83df04c to 33d2629 Compare October 17, 2024 11:13
@crishpeen crishpeen force-pushed the docs/web-migration-general-changes branch from cbfc143 to 1539c9f Compare October 17, 2024 11:16
docs/migrations/web/MIGRATION-v3.md Outdated Show resolved Hide resolved
docs/migrations/web/MIGRATION-v3.md Outdated Show resolved Hide resolved
docs/migrations/web/MIGRATION-v3.md Outdated Show resolved Hide resolved
docs/migrations/web/MIGRATION-v3.md Outdated Show resolved Hide resolved
docs/migrations/web/MIGRATION-v3.md Outdated Show resolved Hide resolved
docs/migrations/web/MIGRATION-v3.md Outdated Show resolved Hide resolved
docs/migrations/web/MIGRATION-v3.md Outdated Show resolved Hide resolved
docs/migrations/web/MIGRATION-v3.md Outdated Show resolved Hide resolved
docs/migrations/web/MIGRATION-v3.md Outdated Show resolved Hide resolved
@literat literat force-pushed the integration/BC-v3-design-tokens branch from 912c9b2 to f5ad8a7 Compare October 17, 2024 14:17
@crishpeen crishpeen force-pushed the docs/web-migration-general-changes branch from 1539c9f to e7c27d7 Compare October 17, 2024 14:21
docs/migrations/web/MIGRATION-v3.md Outdated Show resolved Hide resolved
docs/migrations/web/MIGRATION-v3.md Outdated Show resolved Hide resolved
docs/migrations/web/MIGRATION-v3.md Outdated Show resolved Hide resolved
docs/migrations/web/MIGRATION-v3.md Outdated Show resolved Hide resolved
docs/migrations/web/MIGRATION-v3.md Outdated Show resolved Hide resolved
@crishpeen crishpeen force-pushed the docs/web-migration-general-changes branch from e7c27d7 to b783fd5 Compare October 17, 2024 14:41
Copy link
Collaborator

@literat literat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice guidelines 👍

@crishpeen crishpeen merged commit 1f22217 into integration/BC-v3-design-tokens Oct 21, 2024
20 checks passed
@crishpeen crishpeen deleted the docs/web-migration-general-changes branch October 21, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants