Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor(web-react): No longer use default props in the rest of the c… #1694

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

crishpeen
Copy link
Member

…omponents

Description

Additional context

Issue reference

@crishpeen crishpeen requested review from literat, pavelklibani, curdaj and a team as code owners October 10, 2024 09:17
@github-actions github-actions bot added the refactoring A code change that neither fixes a bug nor adds a feature label Oct 10, 2024
Copy link

netlify bot commented Oct 10, 2024

Deploy Preview for spirit-design-system-storybook ready!

Name Link
🔨 Latest commit 281975d
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/6710d8b38892f0000856ee9f
😎 Deploy Preview https://deploy-preview-1694--spirit-design-system-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 10, 2024

Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit 281975d
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/6710d8b3bc02000007cd1fc3
😎 Deploy Preview https://deploy-preview-1694--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 96 (no change from production)
Accessibility: 93 (no change from production)
Best Practices: 100 (no change from production)
SEO: 82 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@literat literat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🦖

@literat literat force-pushed the refactor/default-props branch from 1060c50 to 281975d Compare October 17, 2024 09:28
@literat literat merged commit 6eebe64 into main Oct 17, 2024
29 checks passed
@literat literat deleted the refactor/default-props branch October 17, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring A code change that neither fixes a bug nor adds a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants