BC(web-react, web-twig): Remove isUnderlined from Link #DS-1509 #1693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for spirit-design-system-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for spirit-design-system ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
pavelklibani
changed the title
crishpeen
reviewed
Oct 10, 2024
.../web-twig/src/Resources/components/Breadcrumbs/__tests__/__fixtures__/breadcrumbsCustom.twig
Show resolved
Hide resolved
pavelklibani
requested review from
literat,
adamkudrna,
a team and
curdaj
as code owners
curdaj
approved these changes
Oct 10, 2024
pavelklibani
changed the title
pavelklibani
changed the title
pavelklibani
force-pushed
the
BC/ds-1509-remove-underline-on-link
branch
from
f1e3577 to
ca1da98
Compare
- removing deprecation - solving #DS-1509
- removing deprecation - solving #DS-1509
pavelklibani
force-pushed
the
BC/ds-1509-remove-underline-on-link
branch
from
ca1da98 to
e56bd3a
Compare
pavelklibani
merged commit 9b2178f
into
integration/BC-v3-design-tokens
29 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Additional context
Some changes were also needed in the Breadcrumbs component, which was using the Link component.
Issue reference
Remove
isUnderlinedprop from Link