BC(web-react, web-twig): elementType in Heading #DS-1482 #1691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelklibani
requested review from
literat,
adamkudrna,
crishpeen,
a team and
curdaj
as code owners
✅ Deploy Preview for spirit-design-system-storybook canceled.
|
✅ Deploy Preview for spirit-design-system ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/11250602075/artifacts/2033566833 |
|
Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/11260808524/artifacts/2036576755 |
pavelklibani
force-pushed
the
BC/ds-1482-heading-element-type
branch
from
2ba406c to
fbb95dc
Compare
pavelklibani
changed the title
curdaj
approved these changes
Oct 11, 2024
pavelklibani
force-pushed
the
BC/ds-1482-heading-element-type
branch
from
d5bdc74 to
73683c0
Compare
pavelklibani
merged commit fa00d88
into
integration/BC-v3-design-tokens
29 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Additional context
Issue reference
Set default element type for Heading component