Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor(ci): Speed up pipeline and make them more readable using emojis #1654

Merged
merged 7 commits into from
Oct 8, 2024

Conversation

literat
Copy link
Collaborator

@literat literat commented Sep 19, 2024

Description

  • it also includes a better caching of node_modules
  • all jobs are now done in under 4 minutes
  • emojis are used for better readability
  • some jobs were separated to run in parallel

Important

Please, check the job names to see if they make sense to you.

Additional context

Issue reference

@github-actions github-actions bot added the maintenance Changes to the build process or auxilary tools and libraries or other maintenance label Sep 19, 2024
Copy link

netlify bot commented Sep 19, 2024

Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit 656df3b
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/67051c449bb5cb0007d9c106
😎 Deploy Preview https://deploy-preview-1654--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 96 (no change from production)
Accessibility: 93 (no change from production)
Best Practices: 100 (no change from production)
SEO: 82 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Sep 19, 2024

Deploy Preview for spirit-design-system-storybook canceled.

Name Link
🔨 Latest commit 656df3b
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/67051c448ae75800081a43d5

@literat literat force-pushed the chore/emoji-pipelines branch 2 times, most recently from e162dd2 to 3a5b307 Compare September 20, 2024 10:26
@literat literat marked this pull request as ready for review September 20, 2024 10:26
@literat literat requested a review from a team as a code owner September 20, 2024 10:26
@literat literat force-pushed the chore/emoji-pipelines branch 2 times, most recently from f843132 to d4d09d9 Compare September 30, 2024 14:47
Copy link
Contributor

@adamkudrna adamkudrna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful! 👏🏻 I love the abstraction of actions, thanks for inspiration 🙂.

.github/actions/setup-install/action.yaml Outdated Show resolved Hide resolved
.github/workflows/e2e.yml Outdated Show resolved Hide resolved
.github/workflows/git.yaml Outdated Show resolved Hide resolved
.github/workflows/e2e.yml Outdated Show resolved Hide resolved
.github/workflows/test-web-twig.yaml Outdated Show resolved Hide resolved
.github/workflows/test-web-twig.yaml Outdated Show resolved Hide resolved
@literat
Copy link
Collaborator Author

literat commented Oct 3, 2024

Beautiful! 👏🏻 I love the abstraction of actions, thanks for inspiration 🙂.

Thanks. I have also applied some newly gained knowledge about caching dependencies. I have summarized it in this post - https://literat.dev/blog/2024-09-13/how-to-cache-not-just-yarn-installs-on-github-actions/

@literat literat force-pushed the chore/emoji-pipelines branch 2 times, most recently from 72fcacc to 6e65c17 Compare October 7, 2024 09:35
@coveralls
Copy link

Coverage Status

coverage: 79.469% (+0.7%) from 78.751%
when pulling 72fcacc on chore/emoji-pipelines
into dbd2d5d on main.

package.json Outdated Show resolved Hide resolved
@literat literat force-pushed the chore/emoji-pipelines branch from 6e65c17 to 656df3b Compare October 8, 2024 11:49
@literat literat merged commit 73ff9ee into main Oct 8, 2024
20 checks passed
@literat literat deleted the chore/emoji-pipelines branch October 8, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Changes to the build process or auxilary tools and libraries or other maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants