Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(web): Switch Slider component to v3 design tokens #DS-1449 #1647

Merged
merged 2 commits into from
Sep 19, 2024
Merged

Feat(web): Switch Slider component to v3 design tokens #DS-1449 #1647

merged 2 commits into from
Sep 19, 2024

Conversation

crishpeen
Copy link
Member

Description

Additional context

Issue reference

@crishpeen crishpeen added the run-visual-tests Runs visual regression testing on this PR label Sep 17, 2024
@github-actions github-actions bot added the feature New feature or request label Sep 17, 2024
@coveralls
Copy link

coveralls commented Sep 17, 2024 •
edited
Loading

Coverage Status

coverage: 78.69% (-0.8%) from 79.452%
when pulling 7d89994 on feat/v3-slider
into acc11a2 on feat/v3-footer.

@coveralls
Copy link

Coverage Status

coverage: 75.075% (-3.6%) from 78.659%
when pulling 0b51161 on feat/v3-slider
into 2b069f1 on integration/BC-v3-design-tokens.

@netlify Netlify
Copy link

netlify bot commented Sep 17, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system-storybook canceled.

Name Link
🔨 Latest commit 9ae7933
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/66ec4d6a8dbb430008673c18

@netlify Netlify
Copy link

netlify bot commented Sep 17, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit 9ae7933
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/66ec4d6aa8106c0008ee88b3
😎 Deploy Preview https://deploy-preview-1647--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 96 (no change from production)
Accessibility: 100 (🟢 up 7 from production)
Best Practices: 100 (no change from production)
SEO: 82 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions GitHub Actions
Copy link
Contributor

Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/10902324696/artifacts/1942377686

@github-actions GitHub Actions
Copy link
Contributor

Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/10902324939/artifacts/1942378318

@crishpeen crishpeen force-pushed the integration/BC-v3-design-tokens branch from 2b069f1 to e4c8059 Compare September 17, 2024 12:18
@crishpeen crishpeen force-pushed the feat/v3-slider branch 2 times, most recently from b240f21 to 34d1c36 Compare September 17, 2024 14:44
adamkudrna
adamkudrna requested changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@adamkudrna adamkudrna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The thumb styling needs to be fixed, otherwise OK.

packages/web/src/scss/components/UNSTABLE_Slider/_tools.scss Outdated Show resolved Hide resolved
packages/web/src/scss/components/UNSTABLE_Slider/_UNSTABLE_Slider.scss Outdated Show resolved Hide resolved
packages/web/src/scss/components/UNSTABLE_Slider/_theme.scss Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/10939406579/artifacts/1952542795

@crishpeen crishpeen force-pushed the integration/BC-v3-design-tokens branch from 2d42419 to 70fab2b Compare September 19, 2024 11:09
@crishpeen crishpeen force-pushed the integration/BC-v3-design-tokens branch from 70fab2b to 8c59b37 Compare September 19, 2024 11:41
@crishpeen crishpeen force-pushed the feat/v3-slider branch 2 times, most recently from b01ea9d to 68c9c32 Compare September 19, 2024 14:21
@crishpeen crishpeen force-pushed the integration/BC-v3-design-tokens branch 2 times, most recently from 7138575 to c3f52eb Compare September 19, 2024 15:09
@github-actions GitHub Actions
Copy link
Contributor

Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/10943813731/artifacts/1953828860

@crishpeen crishpeen force-pushed the integration/BC-v3-design-tokens branch from c3f52eb to 7e531b9 Compare September 19, 2024 15:18
@github-actions GitHub Actions
Copy link
Contributor

Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/10943969977/artifacts/1953899761

@crishpeen crishpeen force-pushed the integration/BC-v3-design-tokens branch from 7e531b9 to 7c9caf7 Compare September 19, 2024 15:48
@crishpeen crishpeen changed the base branch from integration/BC-v3-design-tokens to feat/v3-footer September 19, 2024 15:49
@crishpeen crishpeen merged commit 2176111 into feat/v3-footer Sep 19, 2024
5 checks passed
@crishpeen crishpeen deleted the feat/v3-slider branch September 19, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamkudrna adamkudrna adamkudrna approved these changes

@literat literat Awaiting requested review from literat

@pavelklibani pavelklibani Awaiting requested review from pavelklibani

@curdaj curdaj Awaiting requested review from curdaj

Assignees

@crishpeen crishpeen

Labels
feature New feature or request run-visual-tests Runs visual regression testing on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crishpeen @coveralls @adamkudrna