Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING CHANGE: Remove action colors from Pill and switch it to v3 design tokens #DS-1446 #1623

Merged
merged 3 commits into from
Sep 17, 2024

Conversation

crishpeen
Copy link
Member

Description

Additional context

Issue reference

@crishpeen crishpeen added the run-visual-tests Runs visual regression testing on this PR label Sep 7, 2024
@github-actions github-actions bot added the BC Breaking change label Sep 7, 2024
Copy link

netlify bot commented Sep 7, 2024

Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit 739730c
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/66e995e5fac0a70008960aac
😎 Deploy Preview https://deploy-preview-1623--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 96 (🟢 up 1 from production)
Accessibility: 100 (🟢 up 7 from production)
Best Practices: 100 (no change from production)
SEO: 82 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@coveralls
Copy link

coveralls commented Sep 7, 2024

Coverage Status

Changes unknown
when pulling 739730c on bc/v3-pill
into ** on integration/BC-v3-design-tokens**.

@crishpeen crishpeen force-pushed the feat/v3-tag branch 2 times, most recently from 4e2420a to 5d5d14e Compare September 10, 2024 14:42
Base automatically changed from feat/v3-tag to integration/BC-v3-design-tokens September 10, 2024 15:28
@crishpeen crishpeen force-pushed the integration/BC-v3-design-tokens branch from 1026e5e to 9e0cf35 Compare September 11, 2024 09:22
Copy link

netlify bot commented Sep 11, 2024

Deploy Preview for spirit-design-system-storybook canceled.

Name Link
🔨 Latest commit 739730c
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/66e995e56e04a9000810d3c6

@crishpeen crishpeen force-pushed the integration/BC-v3-design-tokens branch from 9e0cf35 to 2c04230 Compare September 11, 2024 11:52
@crishpeen crishpeen force-pushed the bc/v3-pill branch 2 times, most recently from 3be15e3 to afddf54 Compare September 17, 2024 06:53
Copy link
Contributor

@crishpeen crishpeen force-pushed the integration/BC-v3-design-tokens branch from 2b069f1 to e4c8059 Compare September 17, 2024 12:18
@crishpeen crishpeen force-pushed the bc/v3-pill branch 2 times, most recently from 1e43576 to 7c0b094 Compare September 17, 2024 14:26
Copy link
Contributor

Copy link
Contributor

@crishpeen crishpeen merged commit 072a0e7 into integration/BC-v3-design-tokens Sep 17, 2024
29 checks passed
@crishpeen crishpeen deleted the bc/v3-pill branch September 17, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BC Breaking change run-visual-tests Runs visual regression testing on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants