Feat(web): Introduce Footer composition #DS-1419
#1618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for spirit-design-system-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for spirit-design-system ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
adamkudrna
changed the title
Footer component #DS-1419
adamkudrna
force-pushed
the
feat/DS-1367-introduce-footer
branch
2 times, most recently
from
ce5cd93 to
1ac8d10
Compare
|
Nice 👍 :-) |
adamkudrna
force-pushed
the
feat/DS-1367-introduce-footer
branch
from
f8c0c5b to
ef3684e
Compare
adamkudrna
requested review from
literat,
crishpeen,
pavelklibani,
curdaj and
a team
as code owners
adamkudrna
changed the title
Footer component #DS-1419Footer composition #DS-1419
crishpeen
reviewed
Sep 10, 2024
|
Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/10908625726/artifacts/1944240028 |
crishpeen
approved these changes
Sep 17, 2024
literat
approved these changes
Sep 18, 2024
pavelklibani
approved these changes
Sep 19, 2024
adamkudrna
force-pushed
the
feat/DS-1367-introduce-footer
branch
from
6ab9cd9 to
0cb52c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Additional context
Footeris just a composition of existing components. No component-specific CSS was needed.TODO
Footercomponent #DS-1419Issue reference
https://jira.almacareer.tech/browse/DS-1419
Originally https://jira.almacareer.tech/browse/DS-1367