Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING CHANGE(web): Introduce themes and use new design tokens for … #1582

Merged
merged 2 commits into from
Aug 27, 2024

Conversation

crishpeen
Copy link
Member

…foundations #DS-1430

Description

Additional context

Issue reference

@github-actions github-actions bot added the BC Breaking change label Aug 18, 2024
Copy link

netlify bot commented Aug 18, 2024

Deploy Preview for spirit-design-system failed. Why did it fail? →

Name Link
🔨 Latest commit 5c3c93b
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/66cd9f200227790008659c20

@coveralls
Copy link

coveralls commented Aug 18, 2024

Coverage Status

Changes unknown
when pulling be8a7a9 on bc/web-introduce-themes
into ** on integration/BC-v3-design-tokens**.

@literat
Copy link
Collaborator

literat commented Aug 19, 2024

Looks good to me 🤷 :-)

@crishpeen
Copy link
Member Author

Before merge, change issue ID to DS-1431

Copy link
Collaborator

@literat literat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🤷

Copy link
Contributor

@pavelklibani pavelklibani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆒

packages/web/src/scss/foundation/_typography.scss Outdated Show resolved Hide resolved
packages/web/src/scss/themes/index.scss Outdated Show resolved Hide resolved
packages/web/src/scss/themes/index.scss Outdated Show resolved Hide resolved
packages/web/src/scss/themes/index.scss Outdated Show resolved Hide resolved
packages/web/src/scss/themes/index.scss Outdated Show resolved Hide resolved
packages/web/src/scss/themes/index.scss Outdated Show resolved Hide resolved
packages/web/src/scss/tools/_links.scss Outdated Show resolved Hide resolved
@crishpeen crishpeen force-pushed the fix/disable-tests-and-scss branch 2 times, most recently from c71b4a4 to 703c5cd Compare August 27, 2024 08:44
Base automatically changed from fix/disable-tests-and-scss to bc/v3-tokens August 27, 2024 08:51
@crishpeen crishpeen force-pushed the bc/web-introduce-themes branch from 464e8b1 to 8c615bc Compare August 27, 2024 09:14
Base automatically changed from bc/v3-tokens to integration/BC-v3-design-tokens August 27, 2024 09:19
@crishpeen crishpeen force-pushed the bc/web-introduce-themes branch from 8c615bc to be8a7a9 Compare August 27, 2024 09:21
@crishpeen crishpeen merged commit 82cf9b0 into integration/BC-v3-design-tokens Aug 27, 2024
6 of 10 checks passed
@crishpeen crishpeen deleted the bc/web-introduce-themes branch August 27, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BC Breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants