Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Temporarily disable all visual tests and SCSS loading #1581

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

crishpeen
Copy link
Member

We need this because everything is broken now.

The plan is to slowly uncomment/unignore everything as we transform components into new tokens.

Description

Additional context

Issue reference

Copy link

netlify bot commented Aug 16, 2024

Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit 703c5cd
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/66cd91e67079100008b409aa
😎 Deploy Preview https://deploy-preview-1581--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 99 (🟢 up 4 from production)
Accessibility: 100 (🟢 up 7 from production)
Best Practices: 100 (no change from production)
SEO: 82 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the bug Something isn't working label Aug 16, 2024
@literat
Copy link
Collaborator

literat commented Aug 16, 2024

I think you also want to exclude the branch from the CI runs:

on:
  push:
    branches:
      - '!bc/variables-*'

@crishpeen crishpeen force-pushed the fix/disable-tests-and-scss branch from 426facb to 49f78a7 Compare August 18, 2024 20:04
@crishpeen
Copy link
Member Author

I think you also want to exclude the branch from the CI runs:

on:
  push:
    branches:
      - '!bc/variables-*'

I fixed the build, do you still think I need it? Now I don't see why, but maybe I miss something :)

@literat
Copy link
Collaborator

literat commented Aug 19, 2024

I fixed the build, do you still think I need it? Now I don't see why, but maybe I miss something :)

I thought that you did not want to run in on CI in this case. 🤷

Copy link
Contributor

@adamkudrna adamkudrna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏🏻 Please, drop a comment every time you comment out a code, and ideally file a cleanup issue for it. It's always a good practice to do so because there is no guarantee we won't change our focus and finish what we do now.

tests/e2e/demo-homepages.spec.ts Outdated Show resolved Hide resolved
tests/e2e/demo-homepages.spec.ts Outdated Show resolved Hide resolved
@crishpeen crishpeen force-pushed the fix/disable-tests-and-scss branch from 49f78a7 to c71b4a4 Compare August 27, 2024 08:35
@coveralls
Copy link

coveralls commented Aug 27, 2024

Coverage Status

coverage: 78.449% (-0.7%) from 79.191%
when pulling 703c5cd on fix/disable-tests-and-scss
into 3619639 on bc/v3-tokens.

@crishpeen crishpeen force-pushed the fix/disable-tests-and-scss branch from c71b4a4 to 703c5cd Compare August 27, 2024 08:44
@crishpeen crishpeen merged commit e43b316 into bc/v3-tokens Aug 27, 2024
11 checks passed
@crishpeen crishpeen deleted the fix/disable-tests-and-scss branch August 27, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants