-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BREAKING CHANGE(design-tokens): Introduce new design tokens structure #DS-1430 #1580
Conversation
❌ Deploy Preview for spirit-design-system failed. Why did it fail? →
|
What about adding the second BC commit by changing the package name to |
|
Ok, good point. Agree.
Well, this will be a little bit complicated: the organization is not ready yet for the public repo, so maybe it will be created as a separate organization for public packages to leverage better security. Anyway, I still think we should rename the scope because we are
Ok, I will do it in the separate PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is one or two things to clarify with the designers, otherwise ✅.
1e4a2b4
to
3619639
Compare
eac04f8
into
integration/BC-v3-design-tokens
Description
Additional context
Issue reference