Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING CHANGE(design-tokens): Introduce new design tokens structure #DS-1430 #1580

Merged
merged 2 commits into from
Aug 27, 2024

Conversation

crishpeen
Copy link
Member

Description

Additional context

Issue reference

@crishpeen crishpeen requested review from literat, adamkudrna and a team as code owners August 16, 2024 14:47
Copy link

netlify bot commented Aug 16, 2024

Deploy Preview for spirit-design-system failed. Why did it fail? →

Name Link
🔨 Latest commit e43b316
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/66cd93b16607b90008fea2b3

@github-actions github-actions bot added the BC Breaking change label Aug 16, 2024
@literat
Copy link
Collaborator

literat commented Aug 19, 2024

What about adding the second BC commit by changing the package name to @almacareer/spirit-design-tokens?

@crishpeen
Copy link
Member Author

crishpeen commented Aug 19, 2024

What about adding the second BC commit by changing the package name to @almacareer/spirit-design-tokens?

  1. I don't want to mix different topics and I want this PR to be merged as soon as possible
  2. I think we should rename the public packages when we move to alma career GH organisation, so it isn't confusing
  3. feel free to create your own PR into the integration branch :P

@literat
Copy link
Collaborator

literat commented Aug 21, 2024

  1. I don't want to mix different topics and I want this PR to be merged as soon as possible

Ok, good point. Agree.

  1. I think we should rename the public packages when we move to the Alma Career GH organization, so it isn't confusing

Well, this will be a little bit complicated: the organization is not ready yet for the public repo, so maybe it will be created as a separate organization for public packages to leverage better security. Anyway, I still think we should rename the scope because we are @almacareer now. And this BC suits well to this purpose.

  1. Feel free to create your own PR into the integration branch :P

Ok, I will do it in the separate PR.

Copy link
Contributor

@adamkudrna adamkudrna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is one or two things to clarify with the designers, otherwise ✅.

packages/design-tokens/README.md Outdated Show resolved Hide resolved
packages/design-tokens/README.md Outdated Show resolved Hide resolved
packages/design-tokens/README.md Outdated Show resolved Hide resolved
packages/design-tokens/README.md Outdated Show resolved Hide resolved
packages/design-tokens/README.md Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Aug 27, 2024

Coverage Status

coverage: 73.908% (-5.3%) from 79.191%
when pulling e43b316 on bc/v3-tokens
into ec96d80 on integration/BC-v3-design-tokens.

@crishpeen crishpeen merged commit eac04f8 into integration/BC-v3-design-tokens Aug 27, 2024
7 of 11 checks passed
@crishpeen crishpeen deleted the bc/v3-tokens branch August 27, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BC Breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants