Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Example NextJS app with pages router #DS-1393 #1577

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Feat: Example NextJS app with pages router #DS-1393 #1577

merged 1 commit into from
Aug 20, 2024

Conversation

curdaj
Copy link
Contributor

@curdaj curdaj commented Aug 14, 2024

Description

Additional context

Issue reference

@netlify Netlify
Copy link

netlify bot commented Aug 14, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit 3ad5070
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/66c49d87274bc900089753f5
😎 Deploy Preview https://deploy-preview-1577--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 96 (no change from production)
Accessibility: 93 (no change from production)
Best Practices: 100 (no change from production)
SEO: 82 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Aug 14, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system-storybook canceled.

Name Link
🔨 Latest commit 3ad5070
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/66c49d87ef541300089980b3

@github-actions github-actions bot added the feature New feature or request label Aug 14, 2024
@curdaj curdaj force-pushed the feat/ds-1393-support-ssr-pages-router branch from 8114aab to d36693b Compare August 16, 2024 13:40
@coveralls
Copy link

coveralls commented Aug 16, 2024 •
edited
Loading

Coverage Status

coverage: 78.435% (+12.2%) from 66.205%
when pulling 3ad5070 on feat/ds-1393-support-ssr-pages-router
into 9e6d045 on main.

@curdaj curdaj marked this pull request as ready for review August 20, 2024 07:15
@curdaj curdaj requested a review from a team as a code owner August 20, 2024 07:15
crishpeen
crishpeen reviewed Aug 20, 2024
View reviewed changes
examples/next-with-pages-router/README.md Outdated Show resolved Hide resolved
examples/next-with-pages-router/README.md Outdated Show resolved Hide resolved
examples/next-with-pages-router/next.config.mjs Outdated Show resolved Hide resolved
examples/next-with-pages-router/src/pages/_app.tsx Show resolved Hide resolved
examples/next-with-pages-router/tsconfig.json Show resolved Hide resolved
crishpeen
crishpeen approved these changes Aug 20, 2024
View reviewed changes
Copy link
Member

@crishpeen crishpeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm and works on my machine 🤷

@curdaj curdaj force-pushed the feat/ds-1393-support-ssr-pages-router branch from b6b0f0f to c7b3c26 Compare August 20, 2024 13:42
@curdaj curdaj force-pushed the feat/ds-1393-support-ssr-pages-router branch from c7b3c26 to 3ad5070 Compare August 20, 2024 13:43
@curdaj curdaj merged commit 7ba942c into main Aug 20, 2024
14 checks passed
@curdaj curdaj deleted the feat/ds-1393-support-ssr-pages-router branch August 20, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crishpeen crishpeen crishpeen approved these changes

@literat literat literat approved these changes

@pavelklibani pavelklibani Awaiting requested review from pavelklibani

Assignees

@curdaj curdaj

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@curdaj @coveralls @literat @crishpeen