Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce Flex layout component #DS-1415 #1576

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Introduce Flex layout component #DS-1415 #1576

merged 1 commit into from
Aug 20, 2024

Conversation

adamkudrna
Copy link
Contributor

@adamkudrna adamkudrna commented Aug 13, 2024 •
edited
Loading

Description

Introduce Flex layout component #DS-1415

Additional context

image

TODO

  • responsive direction
  • responsive alignmentX
  • responsive alignmentY
  • responsive wrapping
  • responsive spacing

Issue reference

https://jira.almacareer.tech/browse/DS-1415

@github-actions github-actions bot added the feature New feature or request label Aug 13, 2024
@netlify Netlify
Copy link

netlify bot commented Aug 13, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit 649dce2
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/66c4751e95151f0008037b8b
😎 Deploy Preview https://deploy-preview-1576--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 96 (no change from production)
Accessibility: 93 (no change from production)
Best Practices: 100 (no change from production)
SEO: 82 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Aug 13, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system-storybook canceled.

Name Link
🔨 Latest commit 649dce2
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/66c4751ed8c19d0008087bda

@adamkudrna adamkudrna mentioned this pull request Aug 13, 2024
Merged
@adamkudrna adamkudrna requested a review from dlouhak August 13, 2024 18:04
@coveralls
Copy link

coveralls commented Aug 13, 2024 •
edited
Loading

Coverage Status

coverage: 78.435% (-0.6%) from 79.015%
when pulling 649dce2 on feat/DS-1415-web-flex
into 77a5ec5 on main.

@adamkudrna adamkudrna added the run-visual-tests Runs visual regression testing on this PR label Aug 19, 2024
@github-actions GitHub Actions
Copy link
Contributor

Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/10459774865/artifacts/1829213206

@adamkudrna adamkudrna force-pushed the feat/DS-1415-web-flex branch from 2600e6c to 758db20 Compare August 19, 2024 20:07
@adamkudrna adamkudrna marked this pull request as ready for review August 19, 2024 20:11
@adamkudrna adamkudrna requested review from literat, pavelklibani, curdaj and a team as code owners August 19, 2024 20:11
dlouhak
dlouhak reviewed Aug 20, 2024
View reviewed changes
Copy link
Contributor

@dlouhak dlouhak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look at this shiny code! ✨🎩

packages/web/src/scss/components/Flex/README.md Show resolved Hide resolved
packages/web/src/scss/components/Flex/_Flex.scss Show resolved Hide resolved
packages/web/src/scss/tools/_spacing.scss Outdated Show resolved Hide resolved
packages/web/src/scss/components/Flex/index.html Outdated Show resolved Hide resolved
packages/web/src/scss/tools/_alignment.scss Show resolved Hide resolved
@adamkudrna adamkudrna force-pushed the feat/DS-1415-web-flex branch from 758db20 to 649dce2 Compare August 20, 2024 10:51
@adamkudrna adamkudrna merged commit 1e0571b into main Aug 20, 2024
15 checks passed
@adamkudrna adamkudrna deleted the feat/DS-1415-web-flex branch August 20, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlouhak dlouhak dlouhak left review comments

@crishpeen crishpeen crishpeen approved these changes

@literat literat Awaiting requested review from literat literat is a code owner

@pavelklibani pavelklibani Awaiting requested review from pavelklibani pavelklibani is a code owner

@curdaj curdaj Awaiting requested review from curdaj curdaj is a code owner

Assignees

@adamkudrna adamkudrna

Labels
feature New feature or request run-visual-tests Runs visual regression testing on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adamkudrna @coveralls @crishpeen @dlouhak