Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(web-react): Add 'use client' to all components #DS-1392 #1563

Merged
merged 1 commit into from
Aug 6, 2024
Merged

Feat(web-react): Add 'use client' to all components #DS-1392 #1563

merged 1 commit into from
Aug 6, 2024

Conversation

pavelklibani
Copy link
Contributor

Description

Additional context

Issue reference

Podpora pro React Server Components

@pavelklibani pavelklibani self-assigned this Jul 25, 2024
@github-actions github-actions bot added the feature New feature or request label Jul 25, 2024
@netlify Netlify
Copy link

netlify bot commented Jul 25, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit 07266e2
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/66b22d4413f72900085b5746
😎 Deploy Preview https://deploy-preview-1563--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 96 (no change from production)
Accessibility: 93 (no change from production)
Best Practices: 100 (no change from production)
SEO: 82 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Jul 25, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system-storybook ready!

Name Link
🔨 Latest commit 07266e2
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/66b22d4459c7a100084d8977
😎 Deploy Preview https://deploy-preview-1563--spirit-design-system-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@pavelklibani pavelklibani changed the title Feat(web-react): Add 'use client' to all components #DS-1392 🚧 Feat(web-react): Add 'use client' to all components #DS-1392 Jul 25, 2024
@coveralls
Copy link

coveralls commented Jul 25, 2024 •
edited
Loading

Coverage Status

coverage: 78.364% (-0.7%) from 79.082%
when pulling 07266e2 on feat/ds-1392-react-server-components
into f159ab0 on main.

@pavelklibani pavelklibani changed the title 🚧 Feat(web-react): Add 'use client' to all components #DS-1392 Feat(web-react): Add 'use client' to all components #DS-1392 Jul 25, 2024
@pavelklibani pavelklibani force-pushed the feat/ds-1392-react-server-components branch from ce2081b to 9d40ccd Compare July 25, 2024 13:32
@literat literat requested a review from vmilersky July 26, 2024 09:38
@literat
Copy link
Collaborator

literat commented Jul 26, 2024

Since I will be on vacation I would like to ask @vmilersky to give this a green if all will be working on the platform-frontends project. Thanks.

@pavelklibani pavelklibani force-pushed the feat/ds-1392-react-server-components branch from 0b01816 to 596077a Compare July 30, 2024 09:39
@pavelklibani pavelklibani added the run-visual-tests Runs visual regression testing on this PR label Jul 30, 2024
@github-actions GitHub Actions
Copy link
Contributor

Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/10159974413/artifacts/1754751408

@pavelklibani pavelklibani force-pushed the feat/ds-1392-react-server-components branch from 596077a to e635b3f Compare July 30, 2024 09:51
@github-actions GitHub Actions
Copy link
Contributor

Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/10160134017/artifacts/1754792679

@pavelklibani pavelklibani force-pushed the feat/ds-1392-react-server-components branch from e635b3f to 704d945 Compare July 30, 2024 11:02
@pavelklibani pavelklibani marked this pull request as ready for review July 31, 2024 07:45
@pavelklibani pavelklibani requested review from literat, curdaj and a team as code owners July 31, 2024 07:45
@curdaj
Copy link
Contributor

curdaj commented Jul 31, 2024

Wouldn't it be good to document it somehow or mention it somewhere?

literat
literat approved these changes Aug 5, 2024
View reviewed changes
Copy link
Collaborator

@literat literat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is looking good. I have to suggest changing the commit message to something like Mark all components as Client components, you can also add a link to the https://react.dev/reference/rsc/use-client and mention that we want to support usage of our components alongside with RSC. Thanks :-)

@literat
Copy link
Collaborator

literat commented Aug 5, 2024

Wouldn't it be good to document it somehow or mention it somewhere?

Maybe add some kind of badge to the package main readme file? It can be written almost everything in the badge content :-)

@pavelklibani pavelklibani force-pushed the feat/ds-1392-react-server-components branch from 704d945 to b1a0371 Compare August 6, 2024 09:54
@pavelklibani
Copy link
Contributor Author

Wouldn't it be good to document it somehow or mention it somewhere?

Maybe add some kind of badge to the package main readme file? It can be written almost everything in the badge content :-)

Badge added to readme file

@pavelklibani pavelklibani force-pushed the feat/ds-1392-react-server-components branch 2 times, most recently from a87283d to 2e8551b Compare August 6, 2024 13:55
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 6, 2024

Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/10267930129/artifacts/1781222701

@pavelklibani pavelklibani force-pushed the feat/ds-1392-react-server-components branch from 2e8551b to 07266e2 Compare August 6, 2024 14:03
@pavelklibani pavelklibani merged commit bc55dd9 into main Aug 6, 2024
21 checks passed
@pavelklibani pavelklibani deleted the feat/ds-1392-react-server-components branch August 6, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@curdaj curdaj curdaj approved these changes

@literat literat literat approved these changes

@vmilersky vmilersky Awaiting requested review from vmilersky

Assignees

@pavelklibani pavelklibani

Labels
feature New feature or request run-visual-tests Runs visual regression testing on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pavelklibani @coveralls @literat @curdaj