Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(web-react): Introduce UNSTABLE_Toggle component #DS-1346 #1545

Merged
merged 1 commit into from
Jul 22, 2024
Merged

Feat(web-react): Introduce UNSTABLE_Toggle component #DS-1346 #1545

merged 1 commit into from
Jul 22, 2024

Conversation

curdaj
Copy link
Contributor

@curdaj curdaj commented Jul 15, 2024

Description

Additional context

Issue reference

@curdaj curdaj added the run-visual-tests Runs visual regression testing on this PR label Jul 15, 2024
@netlify Netlify
Copy link

netlify bot commented Jul 15, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit c303e7e
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/669e356b42dc6e0008448275
😎 Deploy Preview https://deploy-preview-1545--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 96 (no change from production)
Accessibility: 93 (no change from production)
Best Practices: 100 (no change from production)
SEO: 82 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@curdaj curdaj changed the title Feat(web-react): Introduce UNSTABLE_Toggle component #DS-1346 🚧 Feat(web-react): Introduce UNSTABLE_Toggle component #DS-1346 Jul 15, 2024
@github-actions github-actions bot added the feature New feature or request label Jul 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/9941482617/artifacts/1702240795

@github-actions GitHub Actions
Copy link
Contributor

Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/9941776580/artifacts/1702329565

@coveralls
Copy link

coveralls commented Jul 15, 2024 •
edited
Loading

Coverage Status

coverage: 78.187% (+0.2%) from 78.016%
when pulling e6055c9 on feat/ds-1346-unstable-toggle-react
into 1e3235e on main.

@pavelklibani
Copy link
Contributor

Add the component to /packages/web-react/scripts/entryPoints.js

@crishpeen crishpeen force-pushed the feat/web-toggle branch 2 times, most recently from b39ec4e to 8a409b8 Compare July 16, 2024 12:07
@curdaj curdaj force-pushed the feat/ds-1346-unstable-toggle-react branch from 02613e7 to 7cd70e1 Compare July 16, 2024 12:26
@github-actions GitHub Actions
Copy link
Contributor

Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/9956792303/artifacts/1706161417

@curdaj curdaj marked this pull request as ready for review July 16, 2024 13:41
@curdaj curdaj requested review from literat, pavelklibani and a team as code owners July 16, 2024 13:41
@curdaj curdaj changed the title 🚧 Feat(web-react): Introduce UNSTABLE_Toggle component #DS-1346 Feat(web-react): Introduce UNSTABLE_Toggle component #DS-1346 Jul 16, 2024
Base automatically changed from feat/web-toggle to main July 16, 2024 16:40
@curdaj curdaj force-pushed the feat/ds-1346-unstable-toggle-react branch from de12442 to dae1e2a Compare July 17, 2024 06:57
@netlify Netlify
Copy link

netlify bot commented Jul 17, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system-storybook ready!

Name Link
🔨 Latest commit e6055c9
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/669e49ad9157c50008bddee8
😎 Deploy Preview https://deploy-preview-1545--spirit-design-system-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions GitHub Actions
Copy link
Contributor

Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/9969612393/artifacts/1709486812

@curdaj curdaj force-pushed the feat/ds-1346-unstable-toggle-react branch from 3c479eb to df1b776 Compare July 17, 2024 07:08
dlouhak
dlouhak reviewed Jul 18, 2024
View reviewed changes
Copy link
Contributor

@dlouhak dlouhak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick look around – LGTM, but a few Toggles in the React demo doesn't toggle. Not sure if it is a problem with deploy or not.

packages/web-react/src/components/UNSTABLE_Toggle/README.md Outdated Show resolved Hide resolved
packages/web-react/src/components/UNSTABLE_Toggle/README.md Outdated Show resolved Hide resolved
packages/web-react/src/components/UNSTABLE_Toggle/README.md Show resolved Hide resolved
packages/web-react/src/components/UNSTABLE_Toggle/UNSTABLE_Toggle.tsx Outdated Show resolved Hide resolved
crishpeen
crishpeen reviewed Jul 18, 2024
View reviewed changes
packages/web-react/src/components/UNSTABLE_Toggle/README.md Outdated Show resolved Hide resolved
packages/web-react/src/components/UNSTABLE_Toggle/README.md Outdated Show resolved Hide resolved
packages/web-react/src/components/UNSTABLE_Toggle/README.md Outdated Show resolved Hide resolved
packages/web-react/src/components/UNSTABLE_Toggle/UNSTABLE_Toggle.tsx Outdated Show resolved Hide resolved
packages/web-react/src/components/UNSTABLE_Toggle/__tests__/UNSTABLE_Toggle.test.tsx Show resolved Hide resolved
packages/web-react/src/components/UNSTABLE_Toggle/stories/UNSTABLE_Toggle.stories.tsx Show resolved Hide resolved
packages/web-react/src/components/UNSTABLE_Toggle/useToggleStyleProps.ts Outdated Show resolved Hide resolved
packages/web-react/src/components/UNSTABLE_Toggle/useToggleStyleProps.ts Outdated Show resolved Hide resolved
packages/web-react/src/types/toggle.ts Outdated Show resolved Hide resolved
packages/web-react/src/components/UNSTABLE_Toggle/demo/index.tsx Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/9989398370/artifacts/1714478130

@github-actions GitHub Actions
Copy link
Contributor

Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/9990231981/artifacts/1714677756

@curdaj curdaj requested a review from crishpeen July 18, 2024 11:03
@curdaj curdaj requested a review from dlouhak July 18, 2024 11:03
pavelklibani
pavelklibani approved these changes Jul 18, 2024
View reviewed changes
Copy link
Contributor

@pavelklibani pavelklibani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

maybe we can create some rule for the imports

packages/web-react/src/components/UNSTABLE_Toggle/__tests__/UNSTABLE_Toggle.test.tsx Outdated Show resolved Hide resolved
packages/web-react/src/components/UNSTABLE_Toggle/__tests__/UNSTABLE_Toggle.test.tsx Outdated Show resolved Hide resolved
packages/web-react/src/components/UNSTABLE_Toggle/demo/ToggleDefault.tsx Show resolved Hide resolved
packages/web-react/src/components/UNSTABLE_Toggle/demo/ToggleDisabled.tsx Outdated Show resolved Hide resolved
packages/web-react/src/components/UNSTABLE_Toggle/demo/ToggleFluid.tsx Outdated Show resolved Hide resolved
packages/web-react/src/components/UNSTABLE_Toggle/demo/ToggleHelperText.tsx Outdated Show resolved Hide resolved
packages/web-react/src/components/UNSTABLE_Toggle/demo/ToggleHiddenLabel.tsx Outdated Show resolved Hide resolved
packages/web-react/src/components/UNSTABLE_Toggle/demo/ToggleIndicators.tsx Outdated Show resolved Hide resolved
packages/web-react/src/components/UNSTABLE_Toggle/demo/ToggleRequired.tsx Outdated Show resolved Hide resolved
packages/web-react/src/components/UNSTABLE_Toggle/demo/ToggleValidation.tsx Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/9993061852/artifacts/1715397490

@curdaj curdaj force-pushed the feat/ds-1346-unstable-toggle-react branch from bd75e4b to d923840 Compare July 19, 2024 09:32
@github-actions GitHub Actions
Copy link
Contributor

Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/10005877449/artifacts/1718474959

@curdaj curdaj force-pushed the feat/ds-1346-unstable-toggle-react branch 2 times, most recently from ba43c53 to 3edd7de Compare July 19, 2024 13:29
@literat literat force-pushed the feat/ds-1346-unstable-toggle-react branch from 2a51b33 to 3edd7de Compare July 19, 2024 15:01
@curdaj curdaj force-pushed the feat/ds-1346-unstable-toggle-react branch 3 times, most recently from 6ae615c to 03d068b Compare July 22, 2024 10:29
@curdaj curdaj force-pushed the feat/ds-1346-unstable-toggle-react branch from c303e7e to e6055c9 Compare July 22, 2024 10:33
@curdaj curdaj force-pushed the feat/ds-1346-unstable-toggle-react branch from fc2f79d to e6055c9 Compare July 22, 2024 11:59
@curdaj curdaj merged commit b20d633 into main Jul 22, 2024
21 checks passed
@curdaj curdaj deleted the feat/ds-1346-unstable-toggle-react branch July 22, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlouhak dlouhak dlouhak approved these changes

@pavelklibani pavelklibani pavelklibani approved these changes

@literat literat literat approved these changes

@adamkudrna adamkudrna Awaiting requested review from adamkudrna

@crishpeen crishpeen Awaiting requested review from crishpeen

Assignees

@curdaj curdaj

Labels
feature New feature or request run-visual-tests Runs visual regression testing on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@curdaj @coveralls @pavelklibani @literat @crishpeen @dlouhak