-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(web): Introduce UNSTABLE Toggle component #DS-1345 #1543
Conversation
✅ Deploy Preview for spirit-design-system ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for spirit-design-system-storybook canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎩 , I have only a few comments.
During the code review, I came up with a few insights, mostly related to the stable version of this component:
- In the Figma it is possible to set if the component has icon or not. This shouldn't be implemented?
-
Should it be possible change state by clicking on the validation/helper text? (related to the Checkbox component, where you probably inspired yourself). And I've also noticed that in the example of validation states the danger variant with multiple error messages doesn't have cursor over label.
-
Nitpicking idea for form components: If there would be a composition of various form components, I can imagine that designer would like to have possibility to set order of the component (toggle-label or label-toggle), because eg.
Checkbox
has input first and then label. The same applies for transitions between checked/unchecked states.
packages/web/src/scss/components/UNSTABLE_Toggle/_UNSTABLE_Toggle.scss
Outdated
Show resolved
Hide resolved
2f1aa95
to
b39ec4e
Compare
Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/9956403469/artifacts/1706068420 |
b39ec4e
to
8a409b8
Compare
Description
Additional context
Issue reference