-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(web): Introduce UNSTABLE_Footer component #DS-1367 #1540
Conversation
✅ Deploy Preview for spirit-design-system-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for spirit-design-system ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
e1ef4c0
to
8f45b85
Compare
d7ef04c
to
d8f404d
Compare
d8f404d
to
5db01a5
Compare
210823a
to
57c8b10
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like the naming (content, utilities, copyright, legal, etc) and don't have time to thoroughly think about it. 🤷
Otherwise, this looks good. We will see how it works out when actually used before we stabilize it.
tests/e2e/demo-homepages.spec.ts-snapshots/web-chromium-linux.png
Outdated
Show resolved
Hide resolved
68f5fd3
to
2cb114a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still don't like the naming and I am afraid that even if we revisit it soon we will leave some remarks of the current one.
But the rest of the code is ok and we can move on.
We agreed to refactor component |
Description
Additional context
Need to be discussed with team:
grid
or we must useflex
?)text-center
Stack
components,Heading
s,Link
s, ... ?Grid
components (currently not possible via API) → DS-1388FooterColumn
would be NTH and should be implemented in the React (DS-1368)FooterColumnItem
as wellIssue reference
https://jira.almacareer.tech/browse/DS-1367
TODOs