Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(web): Introduce UNSTABLE_Footer component #DS-1367 #1540

Closed
wants to merge 1 commit into from

Conversation

dlouhak
Copy link
Contributor

@dlouhak dlouhak commented Jul 8, 2024

Description

Additional context

Need to be discussed with team:

  • unification color design tokens with design
  • dynamic columns and its horizontal centering (is it possible to use grid or we must use flex?)
    • compose with Grid components
  • horizontal alignment of the copyright links (e.g. Jobs aligns links on mobile to the left)
    • user can use utility text-center
  • what should be subcomponent and what shouldn't – should the user set himself
    • variable gap in the Stack components,
      • let the user handle it
    • inverted color variants in the Headings, Links, ... ?
      • let the user handle it
    • variable gap in the Grid components (currently not possible via API) → DS-1388
  • should we decompose component into subcomponent (FooterColumn, FooterHeading, …)?
    • FooterColumn would be NTH and should be implemented in the React (DS-1368)
    • consider FooterColumnItem as well

Issue reference

https://jira.almacareer.tech/browse/DS-1367

TODOs

  • reformat code examples in the README.md
  • generate E2E test screenshots

@dlouhak dlouhak added the feature New feature or request label Jul 8, 2024
@dlouhak dlouhak self-assigned this Jul 8, 2024
Copy link

netlify bot commented Jul 8, 2024

Deploy Preview for spirit-design-system-storybook ready!

Name Link
🔨 Latest commit 2cb114a
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/669f94c613b16a0007b42faf
😎 Deploy Preview https://deploy-preview-1540--spirit-design-system-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jul 8, 2024

Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit 2cb114a
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/669f94c6fb5f230008937ee6
😎 Deploy Preview https://deploy-preview-1540--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 96 (no change from production)
Accessibility: 93 (no change from production)
Best Practices: 100 (no change from production)
SEO: 82 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@dlouhak dlouhak force-pushed the feat/DS-1367-introduce-footer branch 2 times, most recently from e1ef4c0 to 8f45b85 Compare July 9, 2024 13:34
@coveralls
Copy link

coveralls commented Jul 9, 2024

Coverage Status

coverage: 78.187% (-0.8%) from 78.944%
when pulling 2cb114a on feat/DS-1367-introduce-footer
into 305b252 on main.

@dlouhak dlouhak force-pushed the feat/DS-1367-introduce-footer branch 2 times, most recently from d7ef04c to d8f404d Compare July 15, 2024 08:54
@dlouhak dlouhak marked this pull request as ready for review July 15, 2024 09:04
@dlouhak dlouhak force-pushed the feat/DS-1367-introduce-footer branch from d8f404d to 5db01a5 Compare July 15, 2024 12:44
@dlouhak dlouhak requested a review from crishpeen July 16, 2024 13:03
@dlouhak dlouhak force-pushed the feat/DS-1367-introduce-footer branch from 210823a to 57c8b10 Compare July 17, 2024 07:35
@dlouhak dlouhak requested a review from curdaj July 18, 2024 12:59
Copy link
Member

@crishpeen crishpeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like the naming (content, utilities, copyright, legal, etc) and don't have time to thoroughly think about it. 🤷

Otherwise, this looks good. We will see how it works out when actually used before we stabilize it.

@dlouhak dlouhak force-pushed the feat/DS-1367-introduce-footer branch from 68f5fd3 to 2cb114a Compare July 23, 2024 11:32
@dlouhak dlouhak requested a review from crishpeen July 23, 2024 11:33
@dlouhak dlouhak requested review from vmilersky and curdaj July 23, 2024 11:33
Copy link
Member

@crishpeen crishpeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still don't like the naming and I am afraid that even if we revisit it soon we will leave some remarks of the current one.

But the rest of the code is ok and we can move on.

@dlouhak
Copy link
Contributor Author

dlouhak commented Jul 30, 2024

We agreed to refactor component Footer. Will be refactored during DS-1419.

@dlouhak dlouhak closed this Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants