Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Slider rendering and align React docs and demo with the web version #1536

Merged
merged 4 commits into from
Jul 9, 2024
Merged

Fix Slider rendering and align React docs and demo with the web version #1536

merged 4 commits into from
Jul 9, 2024

Conversation

adamkudrna
Copy link
Contributor

Description

obrazek

Additional context

  • Fixed rendering in Chromium browsers
  • Introduce disabled state
  • Remove require and selected states
  • Improve README of React implementation

Issue reference

https://jira.almacareer.tech/browse/DS-1325

@adamkudrna adamkudrna self-assigned this Jul 2, 2024
@adamkudrna adamkudrna added the run-visual-tests Runs visual regression testing on this PR label Jul 2, 2024
@github-actions github-actions bot added the feature New feature or request label Jul 2, 2024
@netlify Netlify
Copy link

netlify bot commented Jul 2, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit 7a04493
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/668d3fc3eec77e0008d4f222
😎 Deploy Preview https://deploy-preview-1536--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 96 (no change from production)
Accessibility: 93 (no change from production)
Best Practices: 100 (no change from production)
SEO: 82 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Jul 2, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system-storybook canceled.

Name Link
🔨 Latest commit 7a04493
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/668d3fc3b9fc880008d9df39

@coveralls
Copy link

Coverage Status

coverage: 78.141%. remained the same
when pulling f8ad545 on feat/react-slider-disabled
into 86ba5ff on main.

literat
literat approved these changes Jul 3, 2024
View reviewed changes
Copy link
Collaborator

@literat literat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks 👍

@dlouhak dlouhak force-pushed the feat/react-slider-disabled branch from 16d4fdc to 0162940 Compare July 9, 2024 10:10
@coveralls
Copy link

coveralls commented Jul 9, 2024 •
edited
Loading

Coverage Status

coverage: 77.951% (-1.1%) from 79.061%
when pulling 7a04493 on feat/react-slider-disabled
into 46ba736 on main.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 9, 2024

Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/9855121494/artifacts/1681496206

@crishpeen crishpeen force-pushed the feat/react-slider-disabled branch from 0162940 to 175a5af Compare July 9, 2024 13:12
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 9, 2024

Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/9857733484/artifacts/1682133819

@crishpeen crishpeen force-pushed the feat/react-slider-disabled branch from 175a5af to ede4c1c Compare July 9, 2024 13:27
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 9, 2024

Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/9857985105/artifacts/1682200719

@crishpeen crishpeen force-pushed the feat/react-slider-disabled branch from ede4c1c to f223318 Compare July 9, 2024 13:40
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 9, 2024

Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/9858180919/artifacts/1682255267

@crishpeen crishpeen force-pushed the feat/react-slider-disabled branch from f223318 to 7a04493 Compare July 9, 2024 13:48
@crishpeen crishpeen merged commit bd48607 into main Jul 9, 2024
14 checks passed
@crishpeen crishpeen deleted the feat/react-slider-disabled branch July 9, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlouhak dlouhak dlouhak approved these changes

@crishpeen crishpeen crishpeen approved these changes

@literat literat literat approved these changes

@pavelklibani pavelklibani Awaiting requested review from pavelklibani pavelklibani is a code owner

@curdaj curdaj Awaiting requested review from curdaj curdaj is a code owner

Assignees

@adamkudrna adamkudrna

Labels
feature New feature or request run-visual-tests Runs visual regression testing on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@adamkudrna @coveralls @literat @crishpeen @dlouhak