Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Introduce UNSTABLE_PartnerLogo component #DS-1356 #1533

Merged
merged 2 commits into from
Jul 9, 2024
Merged

Feat: Introduce UNSTABLE_PartnerLogo component #DS-1356 #1533

merged 2 commits into from
Jul 9, 2024

Conversation

curdaj
Copy link
Contributor

@curdaj curdaj commented Jun 28, 2024

Description

Additional context

Issue reference

@github-actions github-actions bot added the feature New feature or request label Jun 28, 2024
@curdaj curdaj force-pushed the feat/ds-1356-introduce-partner-logo branch from 49eb11c to 71f3148 Compare June 28, 2024 10:57
@netlify Netlify
Copy link

netlify bot commented Jun 28, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system-storybook ready!

Name Link
🔨 Latest commit 49eb11c
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/667e96f73ef2ce0008f6e5a3
😎 Deploy Preview https://deploy-preview-1533--spirit-design-system-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Jun 28, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit b47dfa7
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/668696dfefe92700085ccd66
😎 Deploy Preview https://deploy-preview-1533--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 96 (no change from production)
Accessibility: 93 (no change from production)
Best Practices: 100 (no change from production)
SEO: 82 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Jun 28, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system-storybook ready!

Name Link
🔨 Latest commit b47dfa7
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/668696df11cb66000881220c
😎 Deploy Preview https://deploy-preview-1533--spirit-design-system-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@curdaj curdaj changed the title Feat: Introduce PartnerLogo component #DS-1356 🚧 Feat: Introduce PartnerLogo component #DS-1356 Jun 28, 2024
@curdaj curdaj changed the title 🚧 Feat: Introduce PartnerLogo component #DS-1356 🚧 Feat: Introduce UNSTABLE_PartnerLogo component #DS-1356 Jun 28, 2024
@curdaj curdaj force-pushed the feat/ds-1356-introduce-partner-logo branch from ea2b78c to b23b3ad Compare July 1, 2024 09:32
@coveralls
Copy link

Coverage Status

coverage: 78.227% (+0.09%) from 78.141%
when pulling b23b3ad on feat/ds-1356-introduce-partner-logo
into 86ba5ff on main.

@coveralls
Copy link

Coverage Status

coverage: 78.227% (+0.09%) from 78.141%
when pulling d4edc0a on feat/ds-1356-introduce-partner-logo
into 86ba5ff on main.

@curdaj curdaj changed the title 🚧 Feat: Introduce UNSTABLE_PartnerLogo component #DS-1356 Feat: Introduce UNSTABLE_PartnerLogo component #DS-1356 Jul 1, 2024
@curdaj curdaj marked this pull request as ready for review July 1, 2024 11:06
@coveralls
Copy link

Coverage Status

coverage: 78.227% (+0.09%) from 78.141%
when pulling 0314dd5 on feat/ds-1356-introduce-partner-logo
into 86ba5ff on main.

@coveralls
Copy link

Coverage Status

coverage: 78.227% (+0.09%) from 78.141%
when pulling 9c782ba on feat/ds-1356-introduce-partner-logo
into 86ba5ff on main.

dlouhak
dlouhak reviewed Jul 2, 2024
View reviewed changes
Copy link
Contributor

@dlouhak dlouhak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@curdaj Two birds with one stone, nice work! I only reviewed web package and left a few comments related to the upcoming and stable version.

packages/web/src/scss/components/UNSTABLE_PartnerLogo/_theme.scss Outdated Show resolved Hide resolved
packages/web/src/scss/components/UNSTABLE_PartnerLogo/_theme.scss Show resolved Hide resolved
packages/web/src/scss/components/UNSTABLE_PartnerLogo/_theme.scss Show resolved Hide resolved
packages/web/src/scss/components/UNSTABLE_PartnerLogo/_UNSTABLE_PartnerLogo.scss Outdated Show resolved Hide resolved
packages/web/src/scss/components/UNSTABLE_PartnerLogo/_UNSTABLE_PartnerLogo.scss Outdated Show resolved Hide resolved
packages/web/src/scss/components/UNSTABLE_PartnerLogo/README.md Outdated Show resolved Hide resolved
packages/web/src/scss/components/UNSTABLE_PartnerLogo/README.md Show resolved Hide resolved
packages/web/src/scss/components/UNSTABLE_PartnerLogo/_UNSTABLE_PartnerLogo.scss Show resolved Hide resolved
packages/web/src/scss/components/UNSTABLE_PartnerLogo/index.html Outdated Show resolved Hide resolved
packages/web/src/scss/components/UNSTABLE_PartnerLogo/index.html Outdated Show resolved Hide resolved
@coveralls
Copy link

Coverage Status

coverage: 78.214% (+0.07%) from 78.141%
when pulling 4111115 on feat/ds-1356-introduce-partner-logo
into 86ba5ff on main.

@coveralls
Copy link

Coverage Status

coverage: 78.214% (+0.07%) from 78.141%
when pulling dcd8e83 on feat/ds-1356-introduce-partner-logo
into 86ba5ff on main.

@coveralls
Copy link

Coverage Status

coverage: 78.214% (+0.07%) from 78.141%
when pulling 13874a3 on feat/ds-1356-introduce-partner-logo
into 86ba5ff on main.

@coveralls
Copy link

Coverage Status

coverage: 78.214% (+0.07%) from 78.141%
when pulling 0405122 on feat/ds-1356-introduce-partner-logo
into 86ba5ff on main.

@curdaj curdaj requested review from dlouhak and pavelklibani July 3, 2024 10:23
@coveralls
Copy link

Coverage Status

coverage: 78.218% (+0.08%) from 78.141%
when pulling b6c2861 on feat/ds-1356-introduce-partner-logo
into 86ba5ff on main.

@coveralls
Copy link

Coverage Status

coverage: 78.218% (+0.08%) from 78.141%
when pulling 1250f79 on feat/ds-1356-introduce-partner-logo
into 86ba5ff on main.

@coveralls
Copy link

Coverage Status

coverage: 78.218% (+0.08%) from 78.141%
when pulling ad75345 on feat/ds-1356-introduce-partner-logo
into 86ba5ff on main.

literat
literat approved these changes Jul 3, 2024
View reviewed changes
Copy link
Collaborator

@literat literat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@dlouhak dlouhak mentioned this pull request Jul 3, 2024
Merged
2 tasks
@curdaj curdaj force-pushed the feat/ds-1356-introduce-partner-logo branch 4 times, most recently from 9d90d5d to 35ae0a8 Compare July 4, 2024 11:04
@coveralls
Copy link

Coverage Status

coverage: 78.218% (+0.08%) from 78.141%
when pulling 00499fd on feat/ds-1356-introduce-partner-logo
into 86ba5ff on main.

@curdaj curdaj force-pushed the feat/ds-1356-introduce-partner-logo branch from 848bf41 to c4a1c8d Compare July 4, 2024 11:10
@curdaj curdaj requested a review from dlouhak July 4, 2024 11:18
@coveralls
Copy link

Coverage Status

coverage: 78.218% (+0.08%) from 78.141%
when pulling c4a1c8d on feat/ds-1356-introduce-partner-logo
into e8a50d9 on main.

@curdaj curdaj force-pushed the feat/ds-1356-introduce-partner-logo branch from 05ea9d7 to b47dfa7 Compare July 4, 2024 12:34
@coveralls
Copy link

Coverage Status

coverage: 78.221% (+0.08%) from 78.141%
when pulling b47dfa7 on feat/ds-1356-introduce-partner-logo
into e8a50d9 on main.

@curdaj curdaj merged commit 79f55b4 into main Jul 9, 2024
17 checks passed
@curdaj curdaj deleted the feat/ds-1356-introduce-partner-logo branch July 9, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmilersky vmilersky vmilersky left review comments

@dlouhak dlouhak dlouhak approved these changes

@pavelklibani pavelklibani pavelklibani approved these changes

@literat literat literat approved these changes

@adamkudrna adamkudrna Awaiting requested review from adamkudrna adamkudrna is a code owner

@crishpeen crishpeen Awaiting requested review from crishpeen crishpeen is a code owner

Assignees

@curdaj curdaj

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@curdaj @coveralls @literat @vmilersky @pavelklibani @dlouhak