Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Add documentation and demo for EmptyState and ActionLayout component #DS-1310 #1512

Conversation

curdaj
Copy link
Contributor

@curdaj curdaj commented Jun 24, 2024

Description

Additional context

Issue reference

Copy link

netlify bot commented Jun 24, 2024

Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit f64961b
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/667ad0872ff2920008b64774
😎 Deploy Preview https://deploy-preview-1512--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 96 (🟢 up 1 from production)
Accessibility: 93 (no change from production)
Best Practices: 100 (no change from production)
SEO: 82 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jun 24, 2024
@curdaj curdaj changed the title Docs: Add documentation and demo for EmptyState and ActionLayout component #DS-1310 🚧 Docs: Add documentation and demo for EmptyState and ActionLayout component #DS-1310 Jun 24, 2024
@curdaj curdaj force-pushed the integration/unstable-emptystate branch from c1e0406 to 3de30c0 Compare June 24, 2024 12:33
@curdaj curdaj force-pushed the docs/ds-1310-emptystate-component-documentation branch from 3b7b3af to d2ebb67 Compare June 24, 2024 12:33
@coveralls
Copy link

Coverage Status

coverage: 96.838% (+17.9%) from 78.921%
when pulling d2ebb67 on docs/ds-1310-emptystate-component-documentation
into 3de30c0 on integration/unstable-emptystate.

@coveralls
Copy link

Coverage Status

coverage: 78.921% (+4.2%) from 74.697%
when pulling 3b7b3af on docs/ds-1310-emptystate-component-documentation
into c1e0406 on integration/unstable-emptystate.

@coveralls
Copy link

Coverage Status

coverage: 78.921%. remained the same
when pulling d2ebb67 on docs/ds-1310-emptystate-component-documentation
into 3de30c0 on integration/unstable-emptystate.

@curdaj curdaj added the run-visual-tests Runs visual regression testing on this PR label Jun 24, 2024
@coveralls
Copy link

Coverage Status

coverage: 78.921%. remained the same
when pulling cdacf79 on docs/ds-1310-emptystate-component-documentation
into 3de30c0 on integration/unstable-emptystate.

@coveralls
Copy link

Coverage Status

coverage: 78.921%. remained the same
when pulling c43ba62 on docs/ds-1310-emptystate-component-documentation
into 3de30c0 on integration/unstable-emptystate.

@coveralls
Copy link

Coverage Status

coverage: 74.457% (-4.5%) from 78.921%
when pulling c43ba62 on docs/ds-1310-emptystate-component-documentation
into 3de30c0 on integration/unstable-emptystate.

@coveralls
Copy link

Coverage Status

coverage: 78.921%. remained the same
when pulling 34317a1 on docs/ds-1310-emptystate-component-documentation
into 3de30c0 on integration/unstable-emptystate.

@coveralls
Copy link

Coverage Status

coverage: 78.141% (-0.8%) from 78.921%
when pulling 34317a1 on docs/ds-1310-emptystate-component-documentation
into 3de30c0 on integration/unstable-emptystate.

@curdaj curdaj force-pushed the docs/ds-1310-emptystate-component-documentation branch from 3cc2032 to da852d8 Compare June 24, 2024 14:06
@coveralls
Copy link

Coverage Status

coverage: 78.921%. remained the same
when pulling da852d8 on docs/ds-1310-emptystate-component-documentation
into 3de30c0 on integration/unstable-emptystate.

@coveralls
Copy link

Coverage Status

coverage: 78.921%. remained the same
when pulling da852d8 on docs/ds-1310-emptystate-component-documentation
into 3de30c0 on integration/unstable-emptystate.

@curdaj curdaj force-pushed the integration/unstable-emptystate branch from 3de30c0 to 652e922 Compare June 24, 2024 14:11
@curdaj curdaj force-pushed the docs/ds-1310-emptystate-component-documentation branch from da852d8 to 66f7e51 Compare June 24, 2024 14:11
@coveralls
Copy link

Coverage Status

coverage: 78.921%. remained the same
when pulling 66f7e51 on docs/ds-1310-emptystate-component-documentation
into 652e922 on integration/unstable-emptystate.

@@ -2,3 +2,79 @@

⚠️ This component is UNSTABLE. It may significantly change at any point in the future.
Please use it with caution.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe something like this: Indicates when there’s no data to show, like when a search has no results. ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually used the text from Jobs DS

@curdaj curdaj marked this pull request as ready for review June 24, 2024 14:20
@curdaj curdaj requested review from adamkudrna, crishpeen, pavelklibani and a team as code owners June 24, 2024 14:20
@curdaj curdaj changed the title 🚧 Docs: Add documentation and demo for EmptyState and ActionLayout component #DS-1310 Docs: Add documentation and demo for EmptyState and ActionLayout component #DS-1310 Jun 24, 2024
@coveralls
Copy link

Coverage Status

coverage: 78.141% (-0.8%) from 78.921%
when pulling 66f7e51 on docs/ds-1310-emptystate-component-documentation
into 652e922 on integration/unstable-emptystate.

@curdaj curdaj force-pushed the integration/unstable-emptystate branch from 652e922 to 5c4fbf6 Compare June 24, 2024 15:18
@curdaj curdaj force-pushed the docs/ds-1310-emptystate-component-documentation branch from 66f7e51 to adf2fa1 Compare June 24, 2024 15:19
@coveralls
Copy link

Coverage Status

coverage: 96.838%. remained the same
when pulling adf2fa1 on docs/ds-1310-emptystate-component-documentation
into 5c4fbf6 on integration/unstable-emptystate.

@coveralls
Copy link

Coverage Status

coverage: 78.141% (-18.7%) from 96.838%
when pulling adf2fa1 on docs/ds-1310-emptystate-component-documentation
into 5c4fbf6 on integration/unstable-emptystate.

@coveralls
Copy link

Coverage Status

coverage: 96.838%. remained the same
when pulling 583ccb4 on docs/ds-1310-emptystate-component-documentation
into 5c4fbf6 on integration/unstable-emptystate.

@coveralls
Copy link

Coverage Status

coverage: 78.141% (-18.7%) from 96.838%
when pulling 583ccb4 on docs/ds-1310-emptystate-component-documentation
into 5c4fbf6 on integration/unstable-emptystate.

2 similar comments
@coveralls
Copy link

Coverage Status

coverage: 78.141% (-18.7%) from 96.838%
when pulling 583ccb4 on docs/ds-1310-emptystate-component-documentation
into 5c4fbf6 on integration/unstable-emptystate.

@coveralls
Copy link

Coverage Status

coverage: 78.141% (-18.7%) from 96.838%
when pulling 583ccb4 on docs/ds-1310-emptystate-component-documentation
into 5c4fbf6 on integration/unstable-emptystate.

@coveralls
Copy link

Coverage Status

coverage: 96.838%. remained the same
when pulling c0bafd1 on docs/ds-1310-emptystate-component-documentation
into 5c4fbf6 on integration/unstable-emptystate.

@coveralls
Copy link

Coverage Status

coverage: 78.141% (-18.7%) from 96.838%
when pulling c0bafd1 on docs/ds-1310-emptystate-component-documentation
into 5c4fbf6 on integration/unstable-emptystate.

@coveralls
Copy link

Coverage Status

coverage: 96.838%. remained the same
when pulling 75cf472 on docs/ds-1310-emptystate-component-documentation
into 5c4fbf6 on integration/unstable-emptystate.

@coveralls
Copy link

Coverage Status

coverage: 78.141% (-18.7%) from 96.838%
when pulling 75cf472 on docs/ds-1310-emptystate-component-documentation
into 5c4fbf6 on integration/unstable-emptystate.

@curdaj curdaj requested a review from literat June 25, 2024 09:38
packages/demo/scss/index.scss Outdated Show resolved Hide resolved
packages/demo/scss/index.scss Outdated Show resolved Hide resolved
@curdaj curdaj force-pushed the docs/ds-1310-emptystate-component-documentation branch from f9bcc1a to f64961b Compare June 25, 2024 14:13
@coveralls
Copy link

Coverage Status

coverage: 96.838%. remained the same
when pulling f64961b on docs/ds-1310-emptystate-component-documentation
into 5c4fbf6 on integration/unstable-emptystate.

@coveralls
Copy link

Coverage Status

coverage: 78.141% (-18.7%) from 96.838%
when pulling f64961b on docs/ds-1310-emptystate-component-documentation
into 5c4fbf6 on integration/unstable-emptystate.

1 similar comment
@coveralls
Copy link

Coverage Status

coverage: 78.141% (-18.7%) from 96.838%
when pulling f64961b on docs/ds-1310-emptystate-component-documentation
into 5c4fbf6 on integration/unstable-emptystate.

@curdaj curdaj merged commit 2b11515 into integration/unstable-emptystate Jun 26, 2024
25 checks passed
@curdaj curdaj deleted the docs/ds-1310-emptystate-component-documentation branch June 26, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation run-visual-tests Runs visual regression testing on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants