-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix(web, web-twig): Demo - Checkbox indeterminate #1497
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelklibani
requested review from
literat,
adamkudrna,
crishpeen,
a team and
curdaj
as code owners
June 20, 2024 10:06
☁️ Nx Cloud ReportCI is running/has finished running commands for commit de57cdd. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution
✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
✅ Deploy Preview for spirit-design-system ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for spirit-design-system-storybook canceled.
|
pavelklibani
force-pushed
the
fix/demo-checkbox-indeterminate
branch
from
June 20, 2024 11:32
de57cdd
to
a651413
Compare
pavelklibani
changed the title
Fix(web, web-twig): Checkbox indeterminate
Fix(web, web-twig): Demo - Checkbox indeterminate
Jun 20, 2024
Commit: |
literat
approved these changes
Jun 20, 2024
- In the demo, there were incorrect IDs in the JavaScript to target the checkboxes
pavelklibani
force-pushed
the
fix/demo-checkbox-indeterminate
branch
from
June 20, 2024 12:13
a651413
to
aefbf0d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Additional context