Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(web, web-twig): Demo - Checkbox indeterminate #1497

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

pavelklibani
Copy link
Contributor

Description

  • In the demo, there were incorrect IDs in the JavaScript to target the checkboxes

Additional context

@pavelklibani pavelklibani self-assigned this Jun 20, 2024
Copy link

nx-cloud bot commented Jun 20, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit de57cdd. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


🟥 Failed Commands
cli run build --scope @lmc-eu/spirit-web* --ignore=@lmc-eu/spirit-demo-app
✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@github-actions github-actions bot added the bug Something isn't working label Jun 20, 2024
Copy link

netlify bot commented Jun 20, 2024

Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit aefbf0d
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/66741d054fc7f500080182ef
😎 Deploy Preview https://deploy-preview-1497--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 96 (🟢 up 2 from production)
Accessibility: 93 (no change from production)
Best Practices: 100 (no change from production)
SEO: 82 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jun 20, 2024

Deploy Preview for spirit-design-system-storybook canceled.

Name Link
🔨 Latest commit aefbf0d
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/66741d05ac5b9b000843fb03

@coveralls
Copy link

Coverage Status

coverage: 96.838%. remained the same
when pulling de57cdd on fix/demo-checkbox-indeterminate
into 1553070 on main.

@pavelklibani pavelklibani force-pushed the fix/demo-checkbox-indeterminate branch from de57cdd to a651413 Compare June 20, 2024 11:32
@coveralls
Copy link

Coverage Status

coverage: 96.838% (+19.1%) from 77.727%
when pulling a651413 on fix/demo-checkbox-indeterminate
into 2d35aee on main.

@pavelklibani pavelklibani changed the title Fix(web, web-twig): Checkbox indeterminate Fix(web, web-twig): Demo - Checkbox indeterminate Jun 20, 2024
@coveralls
Copy link

Coverage Status

coverage: 77.727%. remained the same
when pulling a651413 on fix/demo-checkbox-indeterminate
into 2d35aee on main.

@literat
Copy link
Collaborator

literat commented Jun 20, 2024

Commit: Fix(web): Id of Checkbox component indeterminate demo

- In the demo, there were incorrect IDs in the JavaScript to target the checkboxes
@pavelklibani pavelklibani force-pushed the fix/demo-checkbox-indeterminate branch from a651413 to aefbf0d Compare June 20, 2024 12:13
@pavelklibani pavelklibani merged commit 84ec8e8 into main Jun 20, 2024
29 checks passed
@pavelklibani pavelklibani deleted the fix/demo-checkbox-indeterminate branch June 20, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants