Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Fix Modal with Dropdown composition #1455

Merged
merged 3 commits into from
Jun 4, 2024

Conversation

literat
Copy link
Collaborator

@literat literat commented Jun 3, 2024

Description

The Dropdown was using an old structure with the render prop.

Additional context

It is not working here: https://spirit-design-system-storybook.netlify.app/?path=/story/examples-compositions-modals--modal-with-dropdown

Issue reference

@literat literat requested review from pavelklibani, curdaj and a team as code owners June 3, 2024 11:56
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jun 3, 2024
Copy link

netlify bot commented Jun 3, 2024

Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit 5ae54b6
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/665daf720d21620008284bfb
😎 Deploy Preview https://deploy-preview-1455--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 96 (no change from production)
Accessibility: 93 (no change from production)
Best Practices: 100 (no change from production)
SEO: 82 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@coveralls
Copy link

Coverage Status

coverage: 78.531%. remained the same
when pulling 5ae54b6 on docs/fix-modal-dropdown-composition
into 4c88e55 on integration/release-v2.

@literat literat merged commit 195baec into integration/release-v2 Jun 4, 2024
14 checks passed
@literat literat deleted the docs/fix-modal-dropdown-composition branch June 4, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants