Style(repo): Replace unicode "heavy check mark" with "check mark" #1436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
literat
requested review from
adamkudrna,
crishpeen,
pavelklibani,
a team and
curdaj
as code owners
✅ Deploy Preview for spirit-design-system ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for spirit-design-system-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
curdaj
approved these changes
May 22, 2024
crishpeen
approved these changes
May 23, 2024
I think, I can wait. The agreement was what I needed so I can do this after the major release. |
adamkudrna
approved these changes
Jun 4, 2024
* we have previously used "heavy check mark" unicode character
that is not recognized by the Prettier v3
* @see: https://www.compart.com/en/unicode/U+2714
* this unicode character is replaced by "check mark" that is lighter
and Prettier to not have problem with it
* @see: https://www.compart.com/en/unicode/U+2713
* it is also more convenient to use the same size of the character
because as oposite to the "check mark" we are using "multiplication"
* @see: https://www.compart.com/en/unicode/U+2715
* @see: prettier/prettier#15572 for more
details about the Prettier problem with thiunicode character
literat
force-pushed
the
style/heavy-check-mark-replace
branch
from
8e8c293 to
57edc34
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
that is not recognized by the Prettier v3
and Prettier do not have a problem with it
because as opposed to the "check mark" we are using "multiplication"
details about the Prettier problem with the Unicode character
Additional context
This modification is necessary for #1021 to be merged.
Issue reference