Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BREAKING CHANGE(web-twig): Rename height and maxHeight ModalDialog props and enhance them #DS-1134 #1434

Merged
merged 1 commit into from
May 23, 2024
Merged

BREAKING CHANGE(web-twig): Rename height and maxHeight ModalDialog props and enhance them #DS-1134 #1434

merged 1 commit into from
May 23, 2024

Conversation

crishpeen
Copy link
Member

Description

Additional context

Issue reference

@crishpeen crishpeen requested review from literat, adamkudrna, pavelklibani and a team as code owners May 21, 2024 21:48
@github-actions github-actions bot added the BC Breaking change label May 21, 2024
@netlify Netlify
Copy link

netlify bot commented May 21, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit 60e20e1
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/664f50006f86cf000821aae6
😎 Deploy Preview https://deploy-preview-1434--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 96 (no change from production)
Accessibility: 93 (no change from production)
Best Practices: 100 (no change from production)
SEO: 82 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@coveralls
Copy link

coveralls commented May 21, 2024 •
edited
Loading

Coverage Status

Changes unknown
when pulling 60e20e1 on bc/twig-modal-custom-height
into ** on integration/release-v2**.

literat
literat approved these changes May 22, 2024
View reviewed changes
Copy link
Collaborator

@literat literat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@crishpeen crishpeen force-pushed the bc/modal-custom-height branch from a35f16d to d55c1f1 Compare May 23, 2024 09:50
@crishpeen crishpeen requested a review from curdaj as a code owner May 23, 2024 09:50
@crishpeen crishpeen force-pushed the bc/modal-custom-height branch from d55c1f1 to adcc1e4 Compare May 23, 2024 09:51
@crishpeen crishpeen force-pushed the bc/twig-modal-custom-height branch from 23f1cc4 to b6a789f Compare May 23, 2024 09:52
Base automatically changed from bc/modal-custom-height to integration/release-v2 May 23, 2024 14:15
@crishpeen crishpeen force-pushed the bc/twig-modal-custom-height branch from b6a789f to 60e20e1 Compare May 23, 2024 14:17
@crishpeen crishpeen merged commit b55b351 into integration/release-v2 May 23, 2024
25 checks passed
@crishpeen crishpeen deleted the bc/twig-modal-custom-height branch May 23, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@curdaj curdaj curdaj approved these changes

@pavelklibani pavelklibani pavelklibani approved these changes

@literat literat literat approved these changes

@adamkudrna adamkudrna Awaiting requested review from adamkudrna

Assignees

@crishpeen crishpeen

Labels
BC Breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@crishpeen @coveralls @literat @pavelklibani @curdaj