Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(web-react): Remove accidental Tabs demo marginTop #1432

Merged
merged 1 commit into from
May 21, 2024

Conversation

crishpeen
Copy link
Member

Description

Additional context

Issue reference

@crishpeen crishpeen requested review from literat, pavelklibani, curdaj and a team as code owners May 21, 2024 13:13
@github-actions github-actions bot added the bug Something isn't working label May 21, 2024
Copy link

netlify bot commented May 21, 2024

Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit 16c6146
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/664c9e0f9a27990008ed9444
😎 Deploy Preview https://deploy-preview-1432--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 95 (🟢 up 1 from production)
Accessibility: 93 (no change from production)
Best Practices: 100 (no change from production)
SEO: 82 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@coveralls
Copy link

Coverage Status

coverage: 78.63% (-18.3%) from 96.911%
when pulling 16c6146 on fix/react-tabs-demo
into 04dfcd3 on integration/release-v2.

2 similar comments
@coveralls
Copy link

Coverage Status

coverage: 78.63% (-18.3%) from 96.911%
when pulling 16c6146 on fix/react-tabs-demo
into 04dfcd3 on integration/release-v2.

@coveralls
Copy link

Coverage Status

coverage: 78.63% (-18.3%) from 96.911%
when pulling 16c6146 on fix/react-tabs-demo
into 04dfcd3 on integration/release-v2.

Copy link
Collaborator

@literat literat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes Visual Tests, right?

@crishpeen crishpeen merged commit 0c51cb5 into integration/release-v2 May 21, 2024
14 checks passed
@crishpeen crishpeen deleted the fix/react-tabs-demo branch May 21, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants