Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BREAKING CHANGE(web-react): Turn off scrolling inside ModalDialog by default #DS-1184 #1430

Merged
merged 1 commit into from
May 21, 2024
Merged

BREAKING CHANGE(web-react): Turn off scrolling inside ModalDialog by default #DS-1184 #1430

merged 1 commit into from
May 21, 2024

Conversation

crishpeen
Copy link
Member

Description

Additional context

Issue reference

@crishpeen crishpeen requested review from literat, pavelklibani, curdaj and a team as code owners May 21, 2024 11:50
@github-actions github-actions bot added the BC Breaking change label May 21, 2024
@netlify Netlify
Copy link

netlify bot commented May 21, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit b9a7c2d
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/664d157ed6a7590008a647dc
😎 Deploy Preview https://deploy-preview-1430--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 96 (🟢 up 1 from production)
Accessibility: 93 (no change from production)
Best Practices: 100 (no change from production)
SEO: 82 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@coveralls
Copy link

coveralls commented May 21, 2024 •
edited
Loading

Coverage Status

coverage: 78.63% (-18.3%) from 96.911%
when pulling b9a7c2d on bc/react-modal-scrollable
into 09bff9a on integration/release-v2.

literat
literat approved these changes May 21, 2024
View reviewed changes
Copy link
Collaborator

@literat literat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@crishpeen crishpeen force-pushed the integration/release-v2 branch from 0c51cb5 to 09bff9a Compare May 21, 2024 21:31
@crishpeen crishpeen requested a review from adamkudrna as a code owner May 21, 2024 21:31
@crishpeen crishpeen force-pushed the bc/react-modal-scrollable branch from 9dde077 to b9a7c2d Compare May 21, 2024 21:43
@crishpeen crishpeen added the run-visual-tests Runs visual regression testing on this PR label May 21, 2024
@crishpeen crishpeen merged commit 48b3f41 into integration/release-v2 May 21, 2024
21 checks passed
@crishpeen crishpeen deleted the bc/react-modal-scrollable branch May 21, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@literat literat literat approved these changes

@pavelklibani pavelklibani Awaiting requested review from pavelklibani

@curdaj curdaj Awaiting requested review from curdaj

@adamkudrna adamkudrna Awaiting requested review from adamkudrna

Assignees

@crishpeen crishpeen

Labels
BC Breaking change run-visual-tests Runs visual regression testing on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crishpeen @coveralls @literat