Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(form-validations): Use GridItem instead of GridSpan in demo #DS-1279 #1428

Merged
merged 1 commit into from
May 21, 2024
Merged

Fix(form-validations): Use GridItem instead of GridSpan in demo #DS-1279 #1428

merged 1 commit into from
May 21, 2024

Conversation

crishpeen
Copy link
Member

Description

Additional context

Issue reference

@crishpeen crishpeen requested review from literat, pavelklibani, curdaj and a team as code owners May 21, 2024 08:03
@github-actions github-actions bot added the bug Something isn't working label May 21, 2024
@netlify Netlify
Copy link

netlify bot commented May 21, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit c7f5d50
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/664c554f86c14f00081881ae
😎 Deploy Preview https://deploy-preview-1428--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 96 (no change from production)
Accessibility: 93 (no change from production)
Best Practices: 100 (no change from production)
SEO: 82 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@coveralls
Copy link

Coverage Status

coverage: 78.723%. remained the same
when pulling c7f5d50 on fix/remove-gridspan
into a4675b8 on integration/release-v2.

literat
literat approved these changes May 21, 2024
View reviewed changes
Copy link
Collaborator

@literat literat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for the fix 👍

@crishpeen crishpeen merged commit a0b9754 into integration/release-v2 May 21, 2024
11 checks passed
@crishpeen crishpeen deleted the fix/remove-gridspan branch May 21, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@curdaj curdaj curdaj approved these changes

@literat literat literat approved these changes

@pavelklibani pavelklibani Awaiting requested review from pavelklibani

Assignees

@crishpeen crishpeen

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crishpeen @coveralls @literat @curdaj