Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(web-react): Warn when icon asset is missing from the map #1421

Merged
merged 1 commit into from
May 17, 2024

Conversation

literat
Copy link
Collaborator

@literat literat commented May 16, 2024

Description

Raise a warning when there is no icon content to be provided. Also, check more strictly the fallback icon and return only when the fallback is matched. Otherwise, raise a warning and return an empty string.

Additional context

Issue reference

@github-actions github-actions bot added the bug Something isn't working label May 16, 2024
Copy link

netlify bot commented May 16, 2024

Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit 031c64a
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/664721e14cfe090008b1f360
😎 Deploy Preview https://deploy-preview-1421--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 96 (🟢 up 1 from production)
Accessibility: 93 (no change from production)
Best Practices: 100 (no change from production)
SEO: 82 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented May 16, 2024

Deploy Preview for spirit-design-system-storybook canceled.

Name Link
🔨 Latest commit 031c64a
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/664721e162526c000886aab7

@literat
Copy link
Collaborator Author

literat commented May 16, 2024

  • Add test for this.

@literat
Copy link
Collaborator Author

literat commented May 16, 2024

@pavelklibani @curdaj @crishpeen This will conflict with the release branch because I think the same problem is similar there. So after the merge, I will do a rebase and fix the future conflict.

@coveralls
Copy link

coveralls commented May 16, 2024

Coverage Status

coverage: 79.544% (+0.1%) from 79.429%
when pulling 031c64a on fix/warn-from-icon-bad-mapgco
into c9797b5 on main.

@literat literat marked this pull request as ready for review May 16, 2024 18:29
@literat literat requested review from pavelklibani, curdaj and a team as code owners May 16, 2024 18:29
@literat literat force-pushed the fix/warn-from-icon-bad-mapgco branch from 0599eea to 031c64a Compare May 17, 2024 09:22
@literat literat merged commit 1f330f9 into main May 17, 2024
17 checks passed
@literat literat deleted the fix/warn-from-icon-bad-mapgco branch May 17, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants