Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING CHANGE: Remove placement classes #DS-1183 #1420

Merged
merged 2 commits into from
May 23, 2024

Conversation

crishpeen
Copy link
Member

Description

Additional context

Issue reference

@crishpeen crishpeen added the run-visual-tests Runs visual regression testing on this PR label May 16, 2024
@github-actions github-actions bot added the BC Breaking change label May 16, 2024
Copy link

netlify bot commented May 16, 2024

Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit c9fb15d
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/664d1872b60f200008122196
😎 Deploy Preview https://deploy-preview-1420--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 96 (🟢 up 1 from production)
Accessibility: 93 (no change from production)
Best Practices: 100 (no change from production)
SEO: 82 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@coveralls
Copy link

coveralls commented May 16, 2024

Coverage Status

Changes unknown
when pulling c9fb15d on bc/remove-class-placement
into ** on integration/release-v2**.

Copy link
Contributor

Copy link
Contributor

@literat literat force-pushed the integration/release-v2 branch from 506f268 to 52cad76 Compare May 17, 2024 12:39
@crishpeen crishpeen force-pushed the bc/remove-class-placement branch from 13ce8f5 to 6bfd3dd Compare May 21, 2024 07:09
Copy link
Contributor

Copy link
Collaborator

@literat literat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@crishpeen crishpeen force-pushed the integration/release-v2 branch from 0c51cb5 to 09bff9a Compare May 21, 2024 21:31
@crishpeen crishpeen force-pushed the bc/remove-class-placement branch from 6bfd3dd to fe0eed4 Compare May 21, 2024 21:33
Copy link
Contributor

crishpeen added 2 commits May 21, 2024 23:55
See the Placement in Tooltip and Dropdown section in the web
package Migration Guide to version 2.
@crishpeen crishpeen force-pushed the bc/remove-class-placement branch from fe0eed4 to c9fb15d Compare May 21, 2024 21:56
@crishpeen crishpeen merged commit f5aa82d into integration/release-v2 May 23, 2024
25 checks passed
@crishpeen crishpeen deleted the bc/remove-class-placement branch May 23, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BC Breaking change run-visual-tests Runs visual regression testing on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants