Renamed Dropdown classes and components #DS-1248 #1416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crishpeen
requested review from
literat,
adamkudrna,
pavelklibani,
a team and
curdaj
as code owners
✅ Deploy Preview for spirit-design-system ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
literat
reviewed
May 16, 2024
literat
force-pushed
the
integration/release-v2
branch
from
506f268 to
52cad76
Compare
crishpeen
force-pushed
the
bc/dropdown-classes
branch
from
4478b49 to
b330279
Compare
curdaj
approved these changes
May 21, 2024
packages/web-react/src/components/Dropdown/__tests__/Dropdown.test.tsx
Outdated
Show resolved
Hide resolved
packages/web-react/src/components/Dropdown/__tests__/Dropdown.test.tsx
Outdated
Show resolved
Hide resolved
packages/web-react/src/components/Dropdown/__tests__/Dropdown.test.tsx
Outdated
Show resolved
Hide resolved
packages/web-react/src/components/Dropdown/__tests__/Dropdown.test.tsx
Outdated
Show resolved
Hide resolved
|
@curdaj thanks for the test suggestion. @crishpeen can we apply them, please? 🙏 |
See the Dropdown: Classes section in the web package Migration Guide to version 2.
See the Dropdown: Components Naming section in the web-twig package Migration Guide to version 3.
crishpeen
force-pushed
the
bc/dropdown-classes
branch
from
b330279 to
5f14fee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Additional context
Issue reference