Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BREAKING CHANGE(web): Turn off scrolling inside ModalDialog by default #DS-1184 #1412

Merged
merged 1 commit into from
May 18, 2024
Merged

BREAKING CHANGE(web): Turn off scrolling inside ModalDialog by default #DS-1184 #1412

merged 1 commit into from
May 18, 2024

Conversation

adamkudrna
Copy link
Contributor

@adamkudrna adamkudrna commented May 15, 2024 •
edited
Loading

Description

  • Make ModalDialog non-scrollable by default, i.e. the whole Modal scrolls when larger than viewport.
  • Clarify how custom height and max height works, limit this feature only to scrollable ModalDialog.

TODO

  • Make custom height demo more interactive

Issue reference

https://jira.almacareer.tech/browse/DS-1184

@netlify Netlify
Copy link

netlify bot commented May 15, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit 8e277b5
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/6648682291a33800079b3134
😎 Deploy Preview https://deploy-preview-1412--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 96 (🟢 up 1 from production)
Accessibility: 93 (no change from production)
Best Practices: 100 (no change from production)
SEO: 82 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the BC Breaking change label May 15, 2024
@coveralls
Copy link

coveralls commented May 15, 2024 •
edited
Loading

Coverage Status

coverage: 78.742% (-18.2%) from 96.911%
when pulling 8e277b5 on bc/modal-scrolling
into 52cad76 on integration/release-v2.

crishpeen
crishpeen reviewed May 16, 2024
View reviewed changes
packages/web/DEPRECATIONS-v2.md Outdated Show resolved Hide resolved
packages/web/src/scss/components/Modal/README.md Outdated Show resolved Hide resolved
packages/web/src/scss/components/Modal/README.md Outdated Show resolved Hide resolved
packages/web/src/scss/components/Modal/README.md Outdated Show resolved Hide resolved
packages/web/src/scss/components/Modal/_ModalDialog.scss Outdated Show resolved Hide resolved
packages/web/src/scss/components/Modal/_theme.scss Outdated Show resolved Hide resolved
packages/web/src/scss/components/Modal/index.html Outdated Show resolved Hide resolved
packages/web/src/scss/components/Modal/index.html Outdated Show resolved Hide resolved
@adamkudrna
Copy link
Contributor Author

Custom height and max height demo was improved in #1422.

@adamkudrna adamkudrna requested a review from crishpeen May 16, 2024 16:32
@literat literat force-pushed the integration/release-v2 branch from 506f268 to 52cad76 Compare May 17, 2024 12:39
@adamkudrna adamkudrna force-pushed the bc/modal-scrolling branch from cf7db9c to a3c58e1 Compare May 18, 2024 08:16
@adamkudrna adamkudrna force-pushed the bc/modal-scrolling branch from a3c58e1 to 8e277b5 Compare May 18, 2024 08:34
@adamkudrna adamkudrna merged commit e568cd2 into integration/release-v2 May 18, 2024
13 checks passed
@adamkudrna adamkudrna deleted the bc/modal-scrolling branch May 18, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@literat literat literat left review comments

@pavelklibani pavelklibani Awaiting requested review from pavelklibani

@curdaj curdaj Awaiting requested review from curdaj

@crishpeen crishpeen Awaiting requested review from crishpeen

Assignees

@adamkudrna adamkudrna

Labels
BC Breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adamkudrna @coveralls @literat @crishpeen