BREAKING CHANGE(web-react): Rename Tabs props and clean up its types #DS-1096 #1405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crishpeen
requested review from
literat,
pavelklibani,
curdaj,
a team and
adamkudrna
as code owners
✅ Deploy Preview for spirit-design-system ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
curdaj
force-pushed
the
integration/release-v2
branch
from
6212b9d to
6bafe41
Compare
|
@crishpeen Please, rebase this first. |
crishpeen
force-pushed
the
bc/react-tabs-props
branch
from
3e4ae81 to
ffb2eef
Compare
curdaj
reviewed
May 9, 2024
packages/web-react/src/components/Tabs/__tests__/TabItem.test.tsx
Outdated
Show resolved
Hide resolved
packages/web-react/src/components/Tabs/__tests__/TabItem.test.tsx
Outdated
Show resolved
Hide resolved
packages/web-react/src/components/Tabs/__tests__/TabItem.test.tsx
Outdated
Show resolved
Hide resolved
packages/web-react/src/components/Tabs/__tests__/TabItem.test.tsx
Outdated
Show resolved
Hide resolved
packages/web-react/src/components/Tabs/__tests__/TabItem.test.tsx
Outdated
Show resolved
Hide resolved
packages/web-react/src/components/Tabs/__tests__/TabItem.test.tsx
Outdated
Show resolved
Hide resolved
|
I've added a few comments in test files, but It could be a topic for discussion about how to write them. So please just take it as an idea. |
adamkudrna
reviewed
May 10, 2024
curdaj
approved these changes
May 13, 2024
pavelklibani
approved these changes
May 14, 2024
packages/codemods/src/transforms/v2/web-react/tabs-tabitem-tabpane-props.ts
Show resolved
Hide resolved
…#DS-1096 Rename TabItem prop `forTab` to `forTabPane`. Rename TabPane prop `tabId` to `id`. See the Tabs: TabItem and TabPane Props section in the web-react package Migration Guide to version 2.
Rename TabItem prop `forTab` to `forTabPane`. Rename TabPane prop `tabId` to `id`.
crishpeen
force-pushed
the
bc/react-tabs-props
branch
from
34a2319 to
88454e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Additional context
Issue reference