-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor(web): Refactor placement transformation to allow input of logical placements #1403
Merged
adamkudrna
merged 1 commit into
bc/remove-non-flow-placements
from
refactor/sass-placement-transformation
May 10, 2024
Merged
Refactor(web): Refactor placement transformation to allow input of logical placements #1403
adamkudrna
merged 1 commit into
bc/remove-non-flow-placements
from
refactor/sass-placement-transformation
May 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamkudrna
requested review from
literat,
crishpeen,
pavelklibani,
curdaj and
a team
as code owners
May 7, 2024 15:04
github-actions
bot
added
the
refactoring
A code change that neither fixes a bug nor adds a feature
label
May 7, 2024
✅ Deploy Preview for spirit-design-system ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
crishpeen
approved these changes
May 7, 2024
LGTM 🤯 💥 |
literat
reviewed
May 7, 2024
literat
reviewed
May 9, 2024
literat
reviewed
May 9, 2024
literat
approved these changes
May 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Great :D The CSS/SCSS is more functional then I expected :-)
crishpeen
force-pushed
the
bc/remove-non-flow-placements
branch
from
May 9, 2024 11:23
fc37a66
to
e316f53
Compare
crishpeen
force-pushed
the
refactor/sass-placement-transformation
branch
from
May 9, 2024 11:25
22d28d6
to
b17b024
Compare
🤪🤯👍 |
curdaj
approved these changes
May 9, 2024
adamkudrna
force-pushed
the
refactor/sass-placement-transformation
branch
from
May 10, 2024 09:21
9e18814
to
e9b364f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The aim is to allow transformation of semi-logical placements like
top-start
,bottom-end
, etc.Examples
Issue reference
https://jira.almacareer.tech/browse/DS-1138