Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor(web): Refactor placement transformation to allow input of logical placements #1403

Conversation

adamkudrna
Copy link
Contributor

@adamkudrna adamkudrna commented May 7, 2024

Description

The aim is to allow transformation of semi-logical placements like top-start, bottom-end, etc.

Examples

// will return 'top-start' (no transformation)
transform('top-start')

// will return 'bottom-start'
transform('top-start', $main-axis-inverse: true)

// will return 'bottom-end'
transform('top-start', $main-axis-inverse: true, $cross-axis-inverse: true)

// will return 'bottom-right'
transform('top-start', $main-axis-inverse: true, $cross-axis-inverse: true, $cross-axis-physical: true)

// will return 'top start'
transform('top-start', $join-with: ' ')

Issue reference

https://jira.almacareer.tech/browse/DS-1138

@github-actions github-actions bot added the refactoring A code change that neither fixes a bug nor adds a feature label May 7, 2024
Copy link

netlify bot commented May 7, 2024

Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit e9b364f
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/663de72951da0f0008a257ee
😎 Deploy Preview https://deploy-preview-1403--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 96 (no change from production)
Accessibility: 93 (no change from production)
Best Practices: 100 (no change from production)
SEO: 82 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@crishpeen
Copy link
Member

LGTM 🤯 💥

@coveralls
Copy link

coveralls commented May 9, 2024

Coverage Status

coverage: 80.157% (-16.2%) from 96.371%
when pulling e9b364f on refactor/sass-placement-transformation
into e316f53 on bc/remove-non-flow-placements.

Copy link
Collaborator

@literat literat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Great :D The CSS/SCSS is more functional then I expected :-)

@crishpeen crishpeen force-pushed the bc/remove-non-flow-placements branch from fc37a66 to e316f53 Compare May 9, 2024 11:23
@crishpeen crishpeen force-pushed the refactor/sass-placement-transformation branch from 22d28d6 to b17b024 Compare May 9, 2024 11:25
@curdaj
Copy link
Contributor

curdaj commented May 9, 2024

🤪🤯👍

@adamkudrna adamkudrna force-pushed the refactor/sass-placement-transformation branch from 9e18814 to e9b364f Compare May 10, 2024 09:21
@adamkudrna adamkudrna merged commit 1b9e665 into bc/remove-non-flow-placements May 10, 2024
13 checks passed
@adamkudrna adamkudrna deleted the refactor/sass-placement-transformation branch May 10, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring A code change that neither fixes a bug nor adds a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants